Address copilot reviews

Author: josbeir

resources/js/app.js

@@ -112,7 +112,14 @@ Alpine.data('packageSearch', () => ({
     },
 
     selectResult(result) {
-        window.open(result.repo_url, '_blank', 'noopener,noreferrer')
+        try {
+            const url = new URL(result.repo_url)
+            if (url.protocol === 'https:') {
+                window.open(url.toString(), '_blank', 'noopener,noreferrer')
+            }
+        } catch {
+            // Invalid URL, ignore
+        }
         this.close()
     },
 

src/Controller/PackagesController.php

@@ -110,7 +110,7 @@ public function autocomplete(): Response
         if (mb_strlen($q) < 2) {
             return $this->response
                 ->withType('application/json')
-                ->withStringBody(json_encode([]));
+                ->withStringBody(json_encode([], JSON_THROW_ON_ERROR));
         }
 
         $packages = $this->Packages
@@ -143,7 +143,7 @@ public function autocomplete(): Response
 
         return $this->response
             ->withType('application/json')
-            ->withStringBody(json_encode($results));
+            ->withStringBody(json_encode($results, JSON_THROW_ON_ERROR));
     }
 
     /**

src/Model/Table/PackagesTable.php

@@ -105,6 +105,8 @@ public function validationDefault(Validator $validator): Validator
      */
     public function findAutocomplete(SelectQuery $query, string $search, int $maxResults = 8): SelectQuery
     {
+        $escapedSearch = str_replace(['%', '_'], ['\%', '\_'], $search);
+
         return $query
             ->find('search', search: ['search' => $search])
             ->contain(['Tags' => function (SelectQuery $q) {
@@ -113,7 +115,7 @@ public function findAutocomplete(SelectQuery $query, string $search, int $maxRes
             ->selectAlso([
                 'name_match' => $query->expr()
                     ->case()
-                    ->when(['Packages.package LIKE' => '%' . $search . '%'])
+                    ->when(['Packages.package LIKE' => '%' . $escapedSearch . '%'])
                     ->then(1, 'integer')
                     ->else(0, 'integer'),
             ])

templates/element/navbar.php

@@ -50,7 +50,7 @@
                                 </div>
                             </div>
                         </li>
-                        <div class="divider my-0"></div>
+                        <li role="separator" class="p-0"><hr class="divider my-0" /></li>
                         <li>
                             <?= $this->Html->link('Sign out', [
                                 'controller' => 'Users',
@@ -92,7 +92,7 @@
                     <li><?= $this->Html->link('Docs', 'https://book.cakephp.org/', ['target' => '_blank', 'rel' => 'noopener']) ?></li>
                     <li><?= $this->Html->link('API', 'https://api.cakephp.org/', ['target' => '_blank', 'rel' => 'noopener']) ?></li>
                     <?php if (!$this->Identity->isLoggedIn()) : ?>
-                        <div class="divider my-0"></div>
+                        <li role="separator" class="p-0"><hr class="divider my-0" /></li>
                         <li>
                             <?= $this->Form->postLink(
                                 'Sign in with GitHub',

templates/element/search.php

@@ -48,7 +48,6 @@
                class="grow min-w-0"
                autocomplete="off"
                role="combobox"
-               aria-expanded="false"
                :aria-expanded="open"
                aria-haspopup="listbox"
                aria-controls="autocomplete-listbox"

tests/TestCase/View/Helper/UserHelperTest.php

@@ -12,8 +12,6 @@
 
 class UserHelperTest extends TestCase
 {
-    protected UserHelper $User;
-
     protected function createHelper(?array $identityData = null): UserHelper
     {
         $request = new ServerRequest();