Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitReleaseManager - pre-release flag #89

Closed
gep13 opened this issue Apr 14, 2017 · 2 comments
Closed

GitReleaseManager - pre-release flag #89

gep13 opened this issue Apr 14, 2017 · 2 comments
Milestone

Comments

@gep13
Copy link
Member

gep13 commented Apr 14, 2017

Currently, we have this:

https://github.com/cake-contrib/Cake.Recipe/blob/develop/Cake.Recipe/Content/gitreleasemanager.cake#L12

Where the pre-release flag is set to true by default. However, based on this discussion:

cake-contrib/Home#5

I no longer believe that this is the case. If we are creating a pre-release version, i.e. 0.1.0-beta0001 or 0.1.0-rc0001, then I think the pre-release flag should be set, and otherwise, if we are just doing 0.1.0, it shouldn't be set.

I am not clear how/where to make that distinction though.

@pascalberger any thoughts on this?

@Jericho
Copy link
Member

Jericho commented Apr 14, 2017

I vote for simply setting it to false because from now on it will be the setting that's used most regularly. Anyway, the release must be reviewed and published manually which means that this setting can be changed when necessary (in my opinion, this should be very rare in fact).

@gep13
Copy link
Member Author

gep13 commented Apr 14, 2017

@Jericho yes, I think I tend to agree with this.

gep13 added a commit that referenced this issue Apr 14, 2017
- As this will be the normal response, which can be overridden as/when required.
@gep13 gep13 added this to the 0.3.0 milestone Apr 14, 2017
@gep13 gep13 closed this as completed Apr 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants