Fix repository root determination order before calling projectRootDirectoryProvider (#624)

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: Pascal Berger <[email protected]>

Author: Copilot

Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe.Tests/Context/State/IssuesStateTests.cs

@@ -69,5 +69,29 @@ DirectoryPath customProvider(IIssuesState state)
             // Then
             capturedState.ShouldNotBeNull().ShouldBe(state);
         }
+
+        [Fact]
+        public void Should_Have_Repository_Root_Directory_Available_In_Provider_Function()
+        {
+            // Given
+            var fixture = new CakeContextFixture();
+
+            DirectoryPath capturedRepositoryRoot = null;
+            DirectoryPath customProvider(IIssuesState state)
+            {
+                capturedRepositoryRoot = state.RepositoryRootDirectory;
+                return state.BuildRootDirectory;
+            }
+
+            // When
+            var state = new IssuesState(
+                fixture.CreateContext(),
+                RepositoryInfoProviderType.CakeGit,
+                customProvider);
+
+            // Then
+            capturedRepositoryRoot.ShouldNotBeNull()
+                .ShouldBe(state.RepositoryRootDirectory);
+        }
     }
 }

Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe/Context/State/IssuesState.cs

@@ -76,14 +76,14 @@ public IssuesState(
         this.BuildRootDirectory = context.MakeAbsolute(context.Directory("./"));
         context.Information("Build script root directory: {0}", this.BuildRootDirectory);
 
-        this.ProjectRootDirectory = projectRootDirectoryProvider?.Invoke(this) ?? this.BuildRootDirectory.Combine("..").Collapse();
-        context.Information("Project root directory: {0}", this.ProjectRootDirectory);
-
         this.RepositoryInfo = DetermineRepositoryInfoProvider(context, repositoryInfoProviderType);
 
         this.RepositoryRootDirectory = this.RepositoryInfo.GetRepositoryRootDirectory(context, this.BuildRootDirectory);
         context.Information("Repository root directory: {0}", this.RepositoryRootDirectory);
 
+        this.ProjectRootDirectory = projectRootDirectoryProvider?.Invoke(this) ?? this.BuildRootDirectory.Combine("..").Collapse();
+        context.Information("Project root directory: {0}", this.ProjectRootDirectory);
+
         this.BuildServer = DetermineBuildServer(context);
         if (this.BuildServer != null)
         {

Cake.Issues.Recipe/Content/data/IssuesData.cake

@@ -105,14 +105,14 @@ public class IssuesData
         this.BuildRootDirectory = context.MakeAbsolute(context.Directory("./"));
         context.Information("Build script root directory: {0}", this.BuildRootDirectory);
 
-        this.ProjectRootDirectory = projectRootDirectoryProvider?.Invoke(this) ?? this.BuildRootDirectory;
-        context.Information("Project root directory: {0}", this.ProjectRootDirectory);
-
         this.RepositoryInfo = DetermineRepositoryInfoProvider(context, repositoryInfoProviderType);
 
         this.RepositoryRootDirectory = context.GitFindRootFromPath(this.BuildRootDirectory);
         context.Information("Repository root directory: {0}", this.RepositoryRootDirectory);
 
+        this.ProjectRootDirectory = projectRootDirectoryProvider?.Invoke(this) ?? this.BuildRootDirectory;
+        context.Information("Project root directory: {0}", this.ProjectRootDirectory);
+
         this.BuildServer = DetermineBuildServer(context);
         if (this.BuildServer != null)
         {