refactor: [shard-distributor]Remove error logs from store level (#7492)

<!-- Describe what has changed in this PR -->
**What changed?**
Removing the "Store failed with internal error." and "Executor not
found." from the store level.

<!-- Tell your future self why have you made these changes -->
**Why?**
Since the error is returned in the call() method, returning the error
message is handled in the higher level.

<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
**How did you test it?**
unit tests & local testing

<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
**Potential risks**
N/A

<!-- Is it notable for release? e.g. schema updates, configuration or
data migration required? If so, please mention it, and also update
CHANGELOG.md -->
**Release notes**
Cleaning up logs.

<!-- Is there any documentation updates should be made for config,
https://cadenceworkflow.io/docs/operation-guide/setup/ ? If so, please
open an PR in https://github.com/cadence-workflow/cadence-docs -->
**Documentation Changes**

---------

Signed-off-by: Gaziza Yestemirova <[email protected]>

Author: gazi-yestemirova

service/sharddistributor/store/wrappers/metered/base.go

@@ -27,7 +27,6 @@ import (
 
 	"github.com/uber/cadence/common/clock"
 	"github.com/uber/cadence/common/log"
-	"github.com/uber/cadence/common/log/tag"
 	"github.com/uber/cadence/common/metrics"
 	"github.com/uber/cadence/service/sharddistributor/store"
 )
@@ -38,18 +37,11 @@ type base struct {
 	timeSource   clock.TimeSource
 }
 
-func (p *base) updateErrorMetricPerNamespace(scope metrics.ScopeIdx, err error, scopeWithNamespaceTags metrics.Scope, logger log.Logger) {
-	logger = logger.Helper()
-
-	switch {
-	case errors.Is(err, store.ErrExecutorNotFound):
+func (p *base) updateErrorMetricPerNamespace(err error, scopeWithNamespaceTags metrics.Scope) {
+	if errors.Is(err, store.ErrExecutorNotFound) {
 		scopeWithNamespaceTags.IncCounter(metrics.ShardDistributorStoreExecutorNotFound)
-		logger.Error("Executor not found.", tag.Error(err), tag.MetricScope(int(scope)))
-	case errors.Is(err, store.ErrShardNotFound):
-		// this is expected, so we don't want to log it
-	default:
-		logger.Error("Store failed with internal error.", tag.Error(err), tag.MetricScope(int(scope))) // int???
 	}
+
 	scopeWithNamespaceTags.IncCounter(metrics.ShardDistributorStoreFailuresPerNamespace)
 }
 
@@ -62,9 +54,8 @@ func (p *base) call(scope metrics.ScopeIdx, op func() error, tags ...metrics.Tag
 	duration := p.timeSource.Since(before)
 	metricsScope.RecordHistogramDuration(metrics.ShardDistributorStoreLatencyHistogramPerNamespace, duration)
 
-	logger := p.logger.Helper()
 	if err != nil {
-		p.updateErrorMetricPerNamespace(scope, err, metricsScope, logger)
+		p.updateErrorMetricPerNamespace(err, metricsScope)
 	}
 	return err
 }

service/sharddistributor/store/wrappers/metered/metered_test.go

@@ -11,7 +11,6 @@ import (
 
 	"github.com/uber/cadence/common/clock"
 	"github.com/uber/cadence/common/log"
-	"github.com/uber/cadence/common/log/tag"
 	"github.com/uber/cadence/common/metrics"
 	"github.com/uber/cadence/common/types"
 	"github.com/uber/cadence/service/sharddistributor/store"
@@ -31,33 +30,19 @@ func TestMeteredStore_GetHeartbeat(t *testing.T) {
 	}
 
 	tests := []struct {
-		name       string
-		setupMocks func(logger *log.MockLogger)
-		error      error
+		name  string
+		error error
 	}{
 		{
-			name:       "Success",
-			setupMocks: func(logger *log.MockLogger) {},
-			error:      nil,
+			name:  "Success",
+			error: nil,
 		},
 		{
-			name: "NotFound",
-			setupMocks: func(logger *log.MockLogger) {
-				logger.EXPECT().Error(
-					"Executor not found.",
-					[]tag.Tag{tag.Error(store.ErrExecutorNotFound), tag.MetricScope(int(metrics.ShardDistributorStoreGetHeartbeatScope))},
-				).Times(1)
-			},
+			name:  "NotFound",
 			error: store.ErrExecutorNotFound,
 		},
 		{
-			name: "Failure",
-			setupMocks: func(logger *log.MockLogger) {
-				logger.EXPECT().Error(
-					"Store failed with internal error.",
-					[]tag.Tag{tag.Error(&types.InternalServiceError{}), tag.MetricScope(int(metrics.ShardDistributorStoreGetHeartbeatScope))},
-				).Times(1)
-			},
+			name:  "Failure",
 			error: &types.InternalServiceError{},
 		},
 	}
@@ -79,7 +64,6 @@ func TestMeteredStore_GetHeartbeat(t *testing.T) {
 			mockLogger.EXPECT().Helper().Return(mockLogger).AnyTimes()
 
 			wrapped := NewStore(mockHandler, metricsClient, mockLogger, timeSource).(*meteredStore)
-			tt.setupMocks(mockLogger)
 
 			gotHeartbeat, gotAssignedState, err := wrapped.GetHeartbeat(context.Background(), _testNamespace, _testExecutorID)