refactor gRPC time filters (#735)

Author: mkolodezny

src/main/java/com/uber/cadence/internal/compatibility/proto/RequestMapper.java

@@ -786,9 +786,7 @@ public static ListClosedWorkflowExecutionsRequest listClosedWorkflowExecutionsRe
     ListClosedWorkflowExecutionsRequest.Builder request =
         ListClosedWorkflowExecutionsRequest.newBuilder()
             .setDomain(t.getDomain())
-            .setPageSize(t.getMaximumPageSize())
-            .setStartTimeFilter(startTimeFilter(t.StartTimeFilter));
-
+            .setPageSize(t.getMaximumPageSize());
     if (t.getExecutionFilter() != null) {
       request.setExecutionFilter(workflowExecutionFilter(t.getExecutionFilter()));
     }
@@ -801,6 +799,9 @@ public static ListClosedWorkflowExecutionsRequest listClosedWorkflowExecutionsRe
     if (t.getNextPageToken() != null) {
       request.setNextPageToken(arrayToByteString(t.getNextPageToken()));
     }
+    if (t.getStartTimeFilter() != null) {
+      request.setStartTimeFilter(startTimeFilter(t.getStartTimeFilter()));
+    }
     return request.build();
   }
 
@@ -812,9 +813,7 @@ public static ListOpenWorkflowExecutionsRequest listOpenWorkflowExecutionsReques
     ListOpenWorkflowExecutionsRequest.Builder request =
         ListOpenWorkflowExecutionsRequest.newBuilder()
             .setDomain(t.getDomain())
-            .setPageSize(t.getMaximumPageSize())
-            .setStartTimeFilter(startTimeFilter(t.StartTimeFilter));
-
+            .setPageSize(t.getMaximumPageSize());
     if (t.getExecutionFilter() != null) {
       request.setExecutionFilter(workflowExecutionFilter(t.getExecutionFilter()));
     }
@@ -824,7 +823,9 @@ public static ListOpenWorkflowExecutionsRequest listOpenWorkflowExecutionsReques
     if (t.getNextPageToken() != null) {
       request.setNextPageToken(arrayToByteString(t.getNextPageToken()));
     }
-
+    if (t.getStartTimeFilter() != null) {
+      request.setStartTimeFilter(startTimeFilter(t.getStartTimeFilter()));
+    }
     return request.build();
   }
 }

src/main/java/com/uber/cadence/internal/compatibility/proto/TypeMapper.java

@@ -231,7 +231,7 @@ static WorkerVersionInfo workerVersionInfo(com.uber.cadence.WorkerVersionInfo t)
 
   static StartTimeFilter startTimeFilter(com.uber.cadence.StartTimeFilter t) {
     if (t == null) {
-      return StartTimeFilter.newBuilder().build();
+      return null;
     }
     return StartTimeFilter.newBuilder()
         .setEarliestTime(unixNanoToTime(t.getEarliestTime()))
@@ -259,7 +259,7 @@ static WorkflowTypeFilter workflowTypeFilter(com.uber.cadence.WorkflowTypeFilter
 
   static StatusFilter statusFilter(com.uber.cadence.WorkflowExecutionCloseStatus t) {
     if (t == null) {
-      return StatusFilter.newBuilder().build();
+      return null;
     }
     return StatusFilter.newBuilder().setStatus(workflowExecutionCloseStatus(t)).build();
   }