Skip to content

Commit cbe12f4

Browse files
authored
fix(examples): drop redundant <chat-subagents> sidebar tray in canonical demo (#722)
After #711 the <chat> composition renders each subagent inline as a persistent chat-subagent-card, so the demo-shell's separate active-only <chat-subagents> sidebar tray double-displayed subagents during a run. Remove it (mount, import, orphaned CSS) to match #718's fix for cockpit/chat/subagents. Also refresh a stale comment in cockpit/ag-ui/subagents.
1 parent 0c949b6 commit cbe12f4

4 files changed

Lines changed: 2 additions & 21 deletions

File tree

cockpit/ag-ui/subagents/angular/src/app/subagents.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ import { ExampleChatLayoutComponent } from '@threadplane/example-layouts';
1212
* subagent-specific wiring is needed in the component: when the orchestrator
1313
* dispatches a `task` tool call, the backend converts the subagent_activity
1414
* CUSTOM events into native AG-UI ACTIVITY events, the @threadplane/ag-ui
15-
* reducer projects them onto `agent.subagents()`, and <chat> renders a
16-
* <chat-subagents> live card for each running subagent.
15+
* reducer projects them onto `agent.subagents()`, and <chat> renders each
16+
* dispatch inline as a persistent `chat-subagent-card`.
1717
*
1818
* Demonstrates the chat-runtime decoupling: same <chat> composition as the
1919
* LangGraph cockpit, AG-UI runtime instead of LangGraph.

examples/chat/angular/src/app/shell/demo-shell.component.css

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -143,18 +143,6 @@
143143
border-radius: var(--ngaf-chat-radius-card, 10px);
144144
}
145145

146-
.demo-shell__subagents {
147-
position: fixed;
148-
left: 50%;
149-
bottom: 96px;
150-
transform: translateX(-50%);
151-
z-index: 997;
152-
width: min(640px, calc(100vw - 32px));
153-
display: flex;
154-
flex-direction: column;
155-
gap: 8px;
156-
}
157-
158146
.demo-shell__theme-toggle {
159147
width: 28px;
160148
height: 28px;

examples/chat/angular/src/app/shell/demo-shell.component.html

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -119,11 +119,6 @@
119119
<chat-interrupt-panel [agent]="agent" (action)="onInterruptAction($event)" />
120120
</div>
121121
}
122-
@if (agent.subagents && agent.subagents().size > 0) {
123-
<div class="demo-shell__subagents" role="region" aria-label="Active subagents">
124-
<chat-subagents [agent]="agent" />
125-
</div>
126-
}
127122
</div>
128123

129124
<chat-history-search-palette

examples/chat/angular/src/app/shell/demo-shell.component.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ import { DEMO_AGENT_REF, type DemoState } from './agent-ref';
1818
import { ThreadplaneTelemetryService } from '@threadplane/telemetry/browser';
1919
import {
2020
ChatInterruptPanelComponent,
21-
ChatSubagentsComponent,
2221
ChatSidenavComponent,
2322
ChatSidenavScrimComponent,
2423
ChatHistorySearchPaletteComponent,
@@ -72,7 +71,6 @@ function parseUrl(url: string): { mode: DemoMode; threadId: string | null } {
7271
imports: [
7372
RouterOutlet,
7473
ChatInterruptPanelComponent,
75-
ChatSubagentsComponent,
7674
ChatSidenavComponent,
7775
ChatSidenavScrimComponent,
7876
ChatHistorySearchPaletteComponent,

0 commit comments

Comments
 (0)