ci: wire root scripts vitest suites into an Nx test target and CI job (#916)

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

Author: blove

.github/workflows/ci.yml

@@ -32,6 +32,7 @@ jobs:
       cockpit_e2e: ${{ steps.scope.outputs.cockpit_e2e }}
       website_e2e: ${{ steps.scope.outputs.website_e2e }}
       posthog: ${{ steps.scope.outputs.posthog }}
+      scripts_tests: ${{ steps.scope.outputs.scripts_tests }}
     steps:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
         with:
@@ -77,6 +78,24 @@ jobs:
       - name: Validate CI workflow guards
         run: node --test scripts/ci-workflow.spec.mjs
 
+  scripts-tests:
+    name: Scripts — generator / proxy vitest suites
+    needs: ci-scope
+    if: github.event_name == 'push' || needs.ci-scope.outputs.scripts_tests == 'true'
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+      - uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
+        with:
+          node-version: 22
+          cache: npm
+      - run: npm ci
+      # Vitest suites for the root deployment/proxy generators (drift checks,
+      # framework-adapter branching, requirements unions, rate limits). The
+      # node:test suites in scripts/ run in ci-scope and library instead —
+      # see scripts/vite.config.mts for the split.
+      - run: npx nx test scripts
+
   library:
     name: Library — lint / test / build
     needs: ci-scope
@@ -543,6 +562,7 @@ jobs:
       - cockpit-e2e-summary
       - website-e2e
       - posthog-sync-plan
+      - scripts-tests
     if: ${{ always() && github.event_name == 'pull_request' }}
     runs-on: ubuntu-latest
     steps:
@@ -561,6 +581,7 @@ jobs:
           RESULT_COCKPIT_E2E: ${{ needs.cockpit-e2e-summary.result }}
           RESULT_WEBSITE_E2E: ${{ needs.website-e2e.result }}
           RESULT_POSTHOG: ${{ needs.posthog-sync-plan.result }}
+          RESULT_SCRIPTS_TESTS: ${{ needs.scripts-tests.result }}
           SCOPE_LIBRARY: ${{ needs.ci-scope.outputs.library }}
           SCOPE_ANGULAR_COMPATIBILITY: ${{ needs.ci-scope.outputs.angular_compatibility }}
           SCOPE_WEBSITE: ${{ needs.ci-scope.outputs.website }}
@@ -572,6 +593,7 @@ jobs:
           SCOPE_COCKPIT_E2E: ${{ needs.ci-scope.outputs.cockpit_e2e }}
           SCOPE_WEBSITE_E2E: ${{ needs.ci-scope.outputs.website_e2e }}
           SCOPE_POSTHOG: ${{ needs.ci-scope.outputs.posthog }}
+          SCOPE_SCRIPTS_TESTS: ${{ needs.ci-scope.outputs.scripts_tests }}
         run: |
           set -euo pipefail
 
@@ -624,6 +646,7 @@ jobs:
           require_scoped "cockpit_e2e" "Cockpit — e2e" "$RESULT_COCKPIT_E2E" "$SCOPE_COCKPIT_E2E"
           require_scoped "website_e2e" "Website — e2e" "$RESULT_WEBSITE_E2E" "$SCOPE_WEBSITE_E2E"
           require_scoped "posthog" "PostHog — dashboards-as-code drift check" "$RESULT_POSTHOG" "$SCOPE_POSTHOG"
+          require_scoped "scripts_tests" "Scripts — generator / proxy vitest suites" "$RESULT_SCRIPTS_TESTS" "$SCOPE_SCRIPTS_TESTS"
 
           if [[ "$failed" -ne 0 ]]; then
             exit 1

scripts/ci-scope.mjs

@@ -16,6 +16,7 @@ export const SCOPE_KEYS = [
   'cockpit_e2e',
   'examples_chat',
   'posthog',
+  'scripts_tests',
 ];
 
 const GLOBAL_CI_FILES = new Set([

scripts/ci-scope.spec.mjs

@@ -338,7 +338,7 @@ describe('classifyFromAffected — tag isolation', () => {
 });
 
 describe('SCOPE_KEYS export', () => {
-  it('contains the 11 documented scope keys', () => {
+  it('contains the 12 documented scope keys', () => {
     assert.deepEqual(SCOPE_KEYS, [
       'library',
       'angular_compatibility',
@@ -351,6 +351,7 @@ describe('SCOPE_KEYS export', () => {
       'cockpit_e2e',
       'examples_chat',
       'posthog',
+      'scripts_tests',
     ]);
   });
 });

scripts/ci-workflow.spec.mjs

@@ -347,6 +347,31 @@ describe('CI workflow', () => {
     );
   });
 
+  it('runs the root scripts vitest suites when the scripts project is affected', async () => {
+    const workflow = await readWorkflow();
+    const scriptsTestsJob = readJobBlock(workflow, 'scripts-tests');
+
+    assert.match(
+      scriptsTestsJob,
+      /if: github\.event_name == 'push' \|\| needs\.ci-scope\.outputs\.scripts_tests == 'true'/
+    );
+    assert.match(scriptsTestsJob, /npx nx test scripts/);
+
+    const requiredPrChecksJob = await readRequiredPrChecksJob();
+    assert.match(
+      requiredPrChecksJob,
+      /RESULT_SCRIPTS_TESTS:\s*\$\{\{\s*needs\.scripts-tests\.result\s*\}\}/
+    );
+    assert.match(
+      requiredPrChecksJob,
+      /SCOPE_SCRIPTS_TESTS:\s*\$\{\{\s*needs\.ci-scope\.outputs\.scripts_tests\s*\}\}/
+    );
+    assert.match(
+      requiredPrChecksJob,
+      /require_scoped "scripts_tests" "Scripts — generator \/ proxy vitest suites"/
+    );
+  });
+
   it('provides one stable required PR check that waits for scoped CI jobs', async () => {
     const requiredPrChecksJob = await readRequiredPrChecksJob();
     const expectedNeeds = [
@@ -363,6 +388,7 @@ describe('CI workflow', () => {
       'cockpit-e2e-summary',
       'website-e2e',
       'posthog-sync-plan',
+      'scripts-tests',
     ];
 
     assert.match(requiredPrChecksJob, /name:\s*CI — required/);

scripts/project.json

@@ -0,0 +1,15 @@
+{
+  "name": "scripts",
+  "$schema": "../node_modules/nx/schemas/project-schema.json",
+  "projectType": "library",
+  "tags": ["scope:scripts-tests", "type:tooling"],
+  "implicitDependencies": [],
+  "targets": {
+    "test": {
+      "executor": "@nx/vitest:test",
+      "options": {
+        "configFile": "scripts/vite.config.mts"
+      }
+    }
+  }
+}

scripts/tsconfig.json

@@ -0,0 +1,14 @@
+{
+  "extends": "../tsconfig.base.json",
+  "compilerOptions": {
+    "module": "esnext",
+    "moduleResolution": "bundler",
+    "target": "es2022",
+    "esModuleInterop": true,
+    "skipLibCheck": true,
+    "resolveJsonModule": true,
+    "types": ["node", "vitest/globals"],
+    "lib": ["es2022"]
+  },
+  "include": ["*.ts", "*.mts"]
+}

scripts/vite.config.mts

@@ -0,0 +1,38 @@
+import { defineConfig } from 'vite';
+
+// Vitest config for the root deployment/proxy generator scripts.
+//
+// Two runners share scripts/: the node:test suites listed in `exclude`
+// below are invoked directly by .github/workflows/ci.yml (`node --test`),
+// everything else matching `include` runs under vitest via `nx test scripts`.
+// A new *.spec.ts / *.spec.mjs file here is picked up automatically; a new
+// node:test suite must be added to `exclude` AND to the ci.yml `node --test`
+// invocation, otherwise vitest fails loudly on it ("no test suite found") —
+// loud-by-default beats silently unrun.
+export default defineConfig({
+  test: {
+    environment: 'node',
+    globals: true,
+    include: ['*.spec.ts', '*.spec.mjs'],
+    exclude: [
+      // node:test suites — run by ci.yml directly, not by vitest.
+      'ci-scope.spec.mjs',
+      'ci-workflow.spec.mjs',
+      'cockpit-matrix.spec.mjs',
+      'cockpit-ports.spec.mjs',
+      'verify-angular-support.spec.mjs',
+      // STALE (excluded deliberately, not a runner mismatch): this one-time
+      // #881 cutover checklist now fails against main on two counts —
+      // libs/licensing is still tracked (and consumed by Angular bundles),
+      // and the Mastra runtime content/lockfiles legitimately mention the
+      // "excluded competitor". Reinstate only after the spec is reconciled
+      // with current policy.
+      'mit-cutover.spec.mjs',
+    ],
+    // Generator specs shell out to `npx tsx` and (re)generate committed
+    // deployment manifests; keep them serial to avoid write races.
+    fileParallelism: false,
+    testTimeout: 60000,
+    hookTimeout: 60000,
+  },
+});