Skip to content

Commit 54b1bf0

Browse files
bloveclaude
andcommitted
fix(libs): run the type-tests targets on the workspace TypeScript
The three `type-tests` targets invoked `npx tsc`, which does not resolve to the workspace compiler. `@dawn-ai/core` pulls in `@typescript/old` (npm:typescript@6.0.2), whose `tsc` bin wins the hoist at `node_modules/.bin/tsc`, so those targets type-checked the public API with TypeScript 6.0.2 while every other target compiles with the declared 5.9.3. That mismatch is what produced the TS5101 `baseUrl` deprecation error, which #1064 silenced with `ignoreDeprecations: "6.0"`. Invoke `node ./node_modules/typescript/bin/tsc` so the targets use the compiler the workspace declares, and drop the `ignoreDeprecations` holding action. The `rootDir` lines stay: they solve the unrelated problem of type-specs importing sibling libraries through path mappings. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 parent 8b18f1a commit 54b1bf0

6 files changed

Lines changed: 3 additions & 12 deletions

File tree

libs/ag-ui/project.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757
"type-tests": {
5858
"executor": "nx:run-commands",
5959
"options": {
60-
"command": "npx tsc --noEmit -p libs/ag-ui/tsconfig.type-tests.json"
60+
"command": "node ./node_modules/typescript/bin/tsc --noEmit -p libs/ag-ui/tsconfig.type-tests.json"
6161
}
6262
},
6363
"prepare-install": {

libs/ag-ui/tsconfig.type-tests.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
"extends": "./tsconfig.lib.json",
33
"compilerOptions": {
44
"noEmit": true,
5-
// This target runs the workspace `tsc` (newer than the build compilers),
6-
// which errors on the inherited baseUrl unless deprecations are ignored.
7-
"ignoreDeprecations": "6.0",
85
// Type-specs import sibling libraries through tsconfig paths; with noEmit
96
// the rootDir only has to be wide enough to contain them.
107
"rootDir": "../..",

libs/chat/project.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757
"type-tests": {
5858
"executor": "nx:run-commands",
5959
"options": {
60-
"command": "npx tsc --project libs/chat/tsconfig.type-tests.json --noEmit"
60+
"command": "node ./node_modules/typescript/bin/tsc --project libs/chat/tsconfig.type-tests.json --noEmit"
6161
}
6262
},
6363
"prepare-install": {

libs/chat/tsconfig.type-tests.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,6 @@
33
"compilerOptions": {
44
"outDir": "../../dist/out-tsc/type-tests",
55
"noEmit": true,
6-
// This target runs the workspace `tsc` (newer than the build compilers),
7-
// which errors on the inherited baseUrl unless deprecations are ignored.
8-
"ignoreDeprecations": "6.0",
96
// Type-specs import sibling libraries through tsconfig paths; with noEmit
107
// the rootDir only has to be wide enough to contain them.
118
"rootDir": "../..",

libs/langgraph/project.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757
"type-tests": {
5858
"executor": "nx:run-commands",
5959
"options": {
60-
"command": "npx tsc --noEmit -p libs/langgraph/tsconfig.type-tests.json"
60+
"command": "node ./node_modules/typescript/bin/tsc --noEmit -p libs/langgraph/tsconfig.type-tests.json"
6161
}
6262
},
6363
"prepare-install": {

libs/langgraph/tsconfig.type-tests.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
"extends": "./tsconfig.lib.json",
33
"compilerOptions": {
44
"noEmit": true,
5-
// This target runs the workspace `tsc` (newer than the build compilers),
6-
// which errors on the inherited baseUrl unless deprecations are ignored.
7-
"ignoreDeprecations": "6.0",
85
// Type-specs import sibling libraries through tsconfig paths; with noEmit
96
// the rootDir only has to be wide enough to contain them.
107
"rootDir": "../..",

0 commit comments

Comments
 (0)