Skip to content

Commit 51cccd9

Browse files
bloveblove
committed
chore(ci): remove placeholder cockpit secret gate
1 parent 7b514f3 commit 51cccd9

14 files changed

Lines changed: 10 additions & 76 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 0 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ jobs:
2626
cockpit: ${{ steps.scope.outputs.cockpit }}
2727
cockpit_examples: ${{ steps.scope.outputs.cockpit_examples }}
2828
cockpit_smoke: ${{ steps.scope.outputs.cockpit_smoke }}
29-
cockpit_secret: ${{ steps.scope.outputs.cockpit_secret }}
3029
cockpit_deploy_smoke: ${{ steps.scope.outputs.cockpit_deploy_smoke }}
3130
examples_chat: ${{ steps.scope.outputs.examples_chat }}
3231
cockpit_e2e: ${{ steps.scope.outputs.cockpit_e2e }}
@@ -198,37 +197,6 @@ jobs:
198197
- run: npm ci
199198
- run: npx nx run-many -t smoke --projects=cockpit-ag-ui-interrupts-python,cockpit-ag-ui-streaming-python,cockpit-deep-agents-planning-python,cockpit-deep-agents-filesystem-python,cockpit-deep-agents-subagents-python,cockpit-deep-agents-memory-python,cockpit-deep-agents-skills-python,cockpit-deep-agents-sandboxes-python,cockpit-langgraph-persistence-python,cockpit-langgraph-durable-execution-python,cockpit-langgraph-streaming-python,cockpit-langgraph-interrupts-python,cockpit-langgraph-memory-python,cockpit-langgraph-subgraphs-python,cockpit-langgraph-time-travel-python,cockpit-langgraph-deployment-runtime-python,cockpit-chat-messages-python,cockpit-render-spec-rendering-python --skip-nx-cache
200199

201-
cockpit-secret-integration:
202-
name: Cockpit — secret-gated integration
203-
needs: ci-scope
204-
if: github.event_name == 'push' || needs.ci-scope.outputs.cockpit_secret == 'true'
205-
runs-on: ubuntu-latest
206-
steps:
207-
- name: Check integration secret
208-
id: integration_secret
209-
run: |
210-
if [ -z "${COCKPIT_SECRET_TOKEN}" ]; then
211-
echo "enabled=false" >> "$GITHUB_OUTPUT"
212-
echo "::notice::Skipping secret-gated integration: COCKPIT_SECRET_TOKEN is not configured"
213-
else
214-
echo "enabled=true" >> "$GITHUB_OUTPUT"
215-
fi
216-
env:
217-
COCKPIT_SECRET_TOKEN: ${{ secrets.COCKPIT_SECRET_TOKEN }}
218-
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
219-
if: steps.integration_secret.outputs.enabled == 'true'
220-
- uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
221-
if: steps.integration_secret.outputs.enabled == 'true'
222-
with:
223-
node-version: 22
224-
cache: npm
225-
- if: steps.integration_secret.outputs.enabled == 'true'
226-
run: npm ci
227-
- if: steps.integration_secret.outputs.enabled == 'true'
228-
run: npx nx run cockpit-langgraph-deployment-runtime-python:integration --skip-nx-cache
229-
env:
230-
COCKPIT_SECRET_TOKEN: ${{ secrets.COCKPIT_SECRET_TOKEN }}
231-
232200
cockpit-deploy-smoke:
233201
name: Cockpit — deploy smoke dry-run
234202
timeout-minutes: 30 # fail fast instead of blocking the main concurrency group on a hang
@@ -505,7 +473,6 @@ jobs:
505473
- cockpit
506474
- cockpit-examples-build
507475
- cockpit-smoke
508-
- cockpit-secret-integration
509476
- cockpit-deploy-smoke
510477
- examples-chat-smoke
511478
- examples-chat-e2e
@@ -523,7 +490,6 @@ jobs:
523490
RESULT_COCKPIT: ${{ needs.cockpit.result }}
524491
RESULT_COCKPIT_EXAMPLES: ${{ needs.cockpit-examples-build.result }}
525492
RESULT_COCKPIT_SMOKE: ${{ needs.cockpit-smoke.result }}
526-
RESULT_COCKPIT_SECRET: ${{ needs.cockpit-secret-integration.result }}
527493
RESULT_COCKPIT_DEPLOY_SMOKE: ${{ needs.cockpit-deploy-smoke.result }}
528494
RESULT_EXAMPLES_CHAT_SMOKE: ${{ needs.examples-chat-smoke.result }}
529495
RESULT_EXAMPLES_CHAT_E2E: ${{ needs.examples-chat-e2e.result }}
@@ -535,7 +501,6 @@ jobs:
535501
SCOPE_COCKPIT: ${{ needs.ci-scope.outputs.cockpit }}
536502
SCOPE_COCKPIT_EXAMPLES: ${{ needs.ci-scope.outputs.cockpit_examples }}
537503
SCOPE_COCKPIT_SMOKE: ${{ needs.ci-scope.outputs.cockpit_smoke }}
538-
SCOPE_COCKPIT_SECRET: ${{ needs.ci-scope.outputs.cockpit_secret }}
539504
SCOPE_COCKPIT_DEPLOY_SMOKE: ${{ needs.ci-scope.outputs.cockpit_deploy_smoke }}
540505
SCOPE_EXAMPLES_CHAT: ${{ needs.ci-scope.outputs.examples_chat }}
541506
SCOPE_COCKPIT_E2E: ${{ needs.ci-scope.outputs.cockpit_e2e }}
@@ -582,7 +547,6 @@ jobs:
582547
require_scoped "cockpit" "Cockpit — build / test" "$RESULT_COCKPIT" "$SCOPE_COCKPIT"
583548
require_scoped "cockpit_examples" "Cockpit — build all examples" "$RESULT_COCKPIT_EXAMPLES" "$SCOPE_COCKPIT_EXAMPLES"
584549
require_scoped "cockpit_smoke" "Cockpit — representative capability smoke" "$RESULT_COCKPIT_SMOKE" "$SCOPE_COCKPIT_SMOKE"
585-
require_scoped "cockpit_secret" "Cockpit — secret-gated integration" "$RESULT_COCKPIT_SECRET" "$SCOPE_COCKPIT_SECRET"
586550
require_scoped "cockpit_deploy_smoke" "Cockpit — deploy smoke dry-run" "$RESULT_COCKPIT_DEPLOY_SMOKE" "$SCOPE_COCKPIT_DEPLOY_SMOKE"
587551
require_scoped "examples_chat" "examples/chat — python smoke" "$RESULT_EXAMPLES_CHAT_SMOKE" "$SCOPE_EXAMPLES_CHAT"
588552
require_scoped "examples_chat" "examples/chat — e2e" "$RESULT_EXAMPLES_CHAT_E2E" "$SCOPE_EXAMPLES_CHAT"
@@ -606,7 +570,6 @@ jobs:
606570
cockpit,
607571
cockpit-examples-build,
608572
cockpit-smoke,
609-
cockpit-secret-integration,
610573
cockpit-deploy-smoke,
611574
examples-chat-smoke,
612575
examples-chat-e2e,

‎cockpit/langgraph/deployment-runtime/python/project.json‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,6 @@
2121
"cwd": "cockpit/langgraph/deployment-runtime/python",
2222
"command": "npx tsx -e \"import { langgraphDeploymentRuntimePythonModule } from './src/index.ts'; const module = langgraphDeploymentRuntimePythonModule; if (module.id !== 'langgraph-deployment-runtime-python' || module.title !== 'LangGraph Deployment Runtime (Python)') { throw new Error('Unexpected module shape for ' + module.id); }\""
2323
}
24-
},
25-
"integration": {
26-
"executor": "nx:run-commands",
27-
"options": {
28-
"cwd": "cockpit/langgraph/deployment-runtime/python",
29-
"command": "npx tsx -e \"const token = process.env.COCKPIT_SECRET_TOKEN; if (!token) { throw new Error('Missing COCKPIT_SECRET_TOKEN'); } console.log('secret-gated integration ready');\""
30-
}
3124
}
3225
},
3326
"tags": [

‎libs/a2ui/project.json‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
"scope:cockpit-deploy-smoke",
99
"scope:cockpit-e2e",
1010
"scope:cockpit-examples",
11-
"scope:cockpit-secret",
1211
"scope:cockpit-smoke",
1312
"scope:examples-chat",
1413
"scope:library",

‎libs/ag-ui/project.json‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
"scope:cockpit-deploy-smoke",
1010
"scope:cockpit-e2e",
1111
"scope:cockpit-examples",
12-
"scope:cockpit-secret",
1312
"scope:cockpit-smoke",
1413
"scope:examples-chat",
1514
"scope:library",

‎libs/chat/project.json‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
"scope:cockpit-deploy-smoke",
1010
"scope:cockpit-e2e",
1111
"scope:cockpit-examples",
12-
"scope:cockpit-secret",
1312
"scope:cockpit-smoke",
1413
"scope:examples-chat",
1514
"scope:library",

‎libs/cockpit-registry/src/lib/manifest.spec.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ describe('cockpitManifest', () => {
132132
expect(aguiTopics).toEqual(expect.arrayContaining(['streaming', 'interrupts']));
133133
});
134134

135-
it('marks secret-gated integration explicitly for deployment runtime', () => {
135+
it('does not advertise placeholder integration coverage for deployment runtime', () => {
136136
const deploymentRuntimeEntry = cockpitManifest.find(
137137
(entry) =>
138138
entry.product === 'langgraph' &&
@@ -144,8 +144,8 @@ describe('cockpitManifest', () => {
144144
runtimeClass: 'deployed-service',
145145
testingContract: {
146146
smokeTarget: 'cockpit-langgraph-deployment-runtime-python:smoke',
147-
integrationTarget: 'cockpit-langgraph-deployment-runtime-python:integration',
148-
integrationMode: 'secret-gated',
147+
integrationTarget: null,
148+
integrationMode: 'none',
149149
deploySmokePath:
150150
'/langgraph/core-capabilities/deployment-runtime/overview/python',
151151
},

‎libs/cockpit-registry/src/lib/manifest.ts‎

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -107,14 +107,6 @@ const getCodeAssetPath = (product: CockpitProduct, topic: string): string =>
107107
const getSmokeTarget = (product: CockpitProduct, topic: string): string =>
108108
`cockpit-${product}-${topic}-python:smoke`;
109109

110-
const getIntegrationTarget = (
111-
product: CockpitProduct,
112-
topic: string
113-
): string | null =>
114-
product === 'langgraph' && topic === 'deployment-runtime'
115-
? 'cockpit-langgraph-deployment-runtime-python:integration'
116-
: null;
117-
118110
const getRuntimeClass = (topic: string): CockpitRuntimeClass =>
119111
topic === 'deployment-runtime' ? 'deployed-service' : 'local-service';
120112

@@ -163,11 +155,8 @@ const createEntry = (
163155
deploymentStatus: 'planned',
164156
testingContract: {
165157
smokeTarget: isDocsOnly ? null : getSmokeTarget(product, topic),
166-
integrationTarget: isDocsOnly ? null : getIntegrationTarget(product, topic),
167-
integrationMode:
168-
isDocsOnly || getIntegrationTarget(product, topic) === null
169-
? 'none'
170-
: 'secret-gated',
158+
integrationTarget: null,
159+
integrationMode: 'none',
171160
deploySmokePath: `/${product}/${section}/${topic}/${page}/python`,
172161
},
173162
};

‎libs/langgraph/project.json‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
"scope:cockpit-deploy-smoke",
1010
"scope:cockpit-e2e",
1111
"scope:cockpit-examples",
12-
"scope:cockpit-secret",
1312
"scope:cockpit-smoke",
1413
"scope:examples-chat",
1514
"scope:library",

‎libs/licensing/project.json‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
"scope:cockpit-deploy-smoke",
99
"scope:cockpit-e2e",
1010
"scope:cockpit-examples",
11-
"scope:cockpit-secret",
1211
"scope:cockpit-smoke",
1312
"scope:examples-chat",
1413
"scope:library",

‎libs/render/project.json‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
"scope:cockpit-deploy-smoke",
1010
"scope:cockpit-e2e",
1111
"scope:cockpit-examples",
12-
"scope:cockpit-secret",
1312
"scope:cockpit-smoke",
1413
"scope:examples-chat",
1514
"scope:library",

0 commit comments

Comments
 (0)