Commit 2cbd506
refactor(website): finish the json-render rename; generalise style contracts
Two follow-ups from #923.
json-render on marketing surfaces
---------------------------------
#923 renamed the docs picker label but deliberately left the marketing
surfaces. They now agree: the homepage FeatureBlock eyebrow, the footer
link, and the three solutions architecture layers all read json-render.
Two hazards this surfaced:
- The footer derives cta_id from the visible label, so renaming the link
would have silently split PostHog's footer_render into a new
footer_json_render series. trackFooterCta now takes an optional
explicit CtaId and the render link pins the original.
- The solutions page maps library name to href through a
Record<string, string>. Renaming the data without the key returns
undefined and renders the card unlinked — no error, no type failure.
solutions-links.spec.ts asserts every layer resolves; mutation-tested
by renaming one side only.
Style contracts
---------------
docs-sidebar-styles.spec.ts guarded two CSS declarations whose loss is
invisible to jsdom, but it was a one-off with an inline parser. It is
replaced by style-contract.ts plus a registry in style-contracts.spec.ts,
so adding a guard is one entry rather than a new file.
Seeded with four live rules, each mutation-tested by deleting the
declaration and by renaming the selector wholesale:
- .docs-sidebar-lib-item-text flex column (the #892 collision)
- .docs-sidebar-lib-menu max-height + overflow-y
- .docs-control-plane position sticky + align-self
- [data-control-plane-pane] overflow-y
Writing the registry found a bug in the extracted parser: a CSS comment
above a rule lands inside the selector capture, so the exact match never
fires and a guarded rule reports as missing. Comments are stripped first.
Also removes the DocsSidebar wrapper and its .docs-sidebar rule, dead
since #892 moved the docs nav into the control plane — only
DocsNavigation is imported, and the sole class usage was inside the dead
component. Its comment documented the same align-self hazard now held by
the .docs-control-plane contract.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>1 parent 69c2d54 commit 2cbd506
11 files changed
Lines changed: 171 additions & 73 deletions
File tree
- apps/website/src
- app
- solutions/[slug]
- components
- docs
- landing
- lib
- styles
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
70 | | - | |
| 70 | + | |
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
26 | 32 | | |
27 | | - | |
| 33 | + | |
28 | 34 | | |
29 | 35 | | |
30 | 36 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
397 | 397 | | |
398 | 398 | | |
399 | 399 | | |
400 | | - | |
401 | | - | |
402 | | - | |
403 | | - | |
404 | | - | |
405 | | - | |
406 | | - | |
407 | | - | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| |||
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
93 | | - | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
94 | 100 | | |
95 | 101 | | |
96 | 102 | | |
97 | | - | |
| 103 | + | |
| 104 | + | |
98 | 105 | | |
99 | 106 | | |
100 | 107 | | |
| |||
200 | 207 | | |
201 | 208 | | |
202 | 209 | | |
203 | | - | |
204 | | - | |
| 210 | + | |
| 211 | + | |
205 | 212 | | |
206 | 213 | | |
207 | 214 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
124 | 124 | | |
125 | 125 | | |
126 | 126 | | |
127 | | - | |
| 127 | + | |
128 | 128 | | |
129 | 129 | | |
130 | 130 | | |
| |||
217 | 217 | | |
218 | 218 | | |
219 | 219 | | |
220 | | - | |
| 220 | + | |
221 | 221 | | |
222 | 222 | | |
223 | 223 | | |
| |||
295 | 295 | | |
296 | 296 | | |
297 | 297 | | |
298 | | - | |
| 298 | + | |
299 | 299 | | |
300 | 300 | | |
301 | 301 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
729 | 729 | | |
730 | 730 | | |
731 | 731 | | |
732 | | - | |
733 | | - | |
734 | | - | |
735 | | - | |
736 | | - | |
737 | | - | |
738 | | - | |
739 | | - | |
740 | | - | |
741 | | - | |
742 | | - | |
743 | 732 | | |
744 | 733 | | |
745 | 734 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
0 commit comments