Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes e2e tests to use CANCER_TYPE rather than tumor type #5077

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rishisulakhe
Copy link

Fix cBioPortal/cbioportal#11321

Describe changes proposed in this pull request:

  • There are several end-to-end tests that color scatter plots based on tumor type .
  • I have changes e2e tests to use CANCER_TYPE rather than tumor type

Checks

  • [ ✓] Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • [ ✓] The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • [✓ ] Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

Copy link

netlify bot commented Jan 3, 2025

Deploy Preview for cbioportalfrontend ready!

Name Link
🔨 Latest commit 45b1887
🔍 Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/677bf9477a2f1d00087debfb
😎 Deploy Preview https://deploy-preview-5077.preview.cbioportal.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rishisulakhe
Copy link
Author

rishisulakhe commented Jan 3, 2025

@inodb @alisman Please review this PR.
If any changes is required please suggest it , i will correct it.
Thankyou.

@inodb inodb added the test label Jan 6, 2025
@rishisulakhe
Copy link
Author

@inodb
Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update e2e tests to use CANCER_TYPE rather than tumor type
2 participants