Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancements to Improved findability of Authorized Studies feature #468

Open
13 of 15 tasks
jagnathan opened this issue Dec 2, 2022 · 12 comments · May be fixed by cBioPortal/cbioportal-frontend#4825 or cBioPortal/cbioportal-frontend#4985
Open
13 of 15 tasks

Enhancements to Improved findability of Authorized Studies feature #468

jagnathan opened this issue Dec 2, 2022 · 12 comments · May be fixed by cBioPortal/cbioportal-frontend#4825 or cBioPortal/cbioportal-frontend#4985
Assignees
@jagnathan

Comments

@jagnathan
Copy link

jagnathan commented Dec 2, 2022 •
edited
Loading

Enhancement to Improved Findability of datasets feature.

https://www.thehyve.nl/articles/improved-findability-of-datasets-in-cbioportal

This feature is enabled or disabled by portal.properties field.

Screen Shot 2023-03-07 at 12 36 17 PM

User level setting for study user
Add a checkbox to allow users to show only authorized studies "Show authorized studies only". By default, this should be checked.

Study level setting for study owner - to be implemented
Provide a study level setting to show or hide the study to unauthorized users for requesting access on home page. If study file does not have this property, then it should default to not showing the study. Frontend and Backend change

Tasks

  • cbioportal docker running
  • Keycloak docker running
  • configure keycloak
  • Make code modifications (see below for files)
  • Connect keycloak and cbioportal docker
  • Test

Files modified

  • src/shared/components/query/CancerStudySelector.tsx
  • src/shared/components/query/QueryStore.ts
  • src/shared/components/query/studyList/StudyList.tsx
  • src/shared/components/query/StudyListLogic.ts
  • src/shared/components/query/filteredSearch/field/CheckboxFilterField.tsx
  • src/shared/components/query/filteredSearch/Phrase.tsx
  • src/shared/lib/query/QueryParser.ts
  • src/shared/components/query/filteredSearch/field/CheckboxFilterField.spec.ts
  • Automated test files
@jagnathan jagnathan self-assigned this Dec 2, 2022
@jagnathan

This comment was marked as outdated.

Sign in to view
@jagnathan

This comment was marked as outdated.

Sign in to view
@jagnathan

This comment was marked as outdated.

Sign in to view
@jagnathan

This comment was marked as outdated.

Sign in to view
@inodb

This comment was marked as outdated.

Sign in to view
This was referenced Feb 16, 2023
Merged
Closed
@jagnathan
Copy link
Author

Screen Shot 2023-03-01 at 12 47 14 PM
With options for both genome and authorization

@jagnathan
Copy link
Author

Screen Shot 2023-03-01 at 12 47 22 PM
Authorized is false - Shows studies without access

@jagnathan
Copy link
Author

Screen Shot 2023-03-01 at 12 47 36 PM
Authorized is true - Shows studies with access

@jagnathan
Copy link
Author

Screen Shot 2023-03-01 at 12 47 56 PM
Error message when trying to select study in not authorized

@jagnathan
Copy link
Author

Screen Shot 2023-03-01 at 12 47 44 PM
No error message when trying to select study is authorized

@jagnathan
Copy link
Author

Screen Shot 2023-03-01 at 12 49 04 PM
Screen Shot 2023-03-01 at 12 49 14 PM
Two filters at the same time.

@jagnathan
Copy link
Author

Some comments are hidden as they have outdated requirements.

@jagnathan jagnathan mentioned this issue Apr 28, 2023
Closed
@jagnathan jagnathan linked a pull request Jan 11, 2024 that will close this issue
Open
3 tasks
@JREastonMarks JREastonMarks transferred this issue from cBioPortal/cbioportal Mar 1, 2024
@jagnathan jagnathan linked a pull request Aug 27, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jagnathan jagnathan

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@inodb @jagnathan