Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DatePicker component from React95 #1

Closed
arturbien opened this issue Mar 22, 2021 · 6 comments
Closed

Use DatePicker component from React95 #1

arturbien opened this issue Mar 22, 2021 · 6 comments
Assignees

Comments

@arturbien
Copy link

Just a suggestion- there's DatePicker component in React95 repo that wasn't released yet because we didn't write tests for it yet. It looks like the original Win95 datepicker and you can find it here: https://github.com/arturbien/React95/tree/master/src/DatePicker

Screenshot 2021-03-22 at 09 35 57

@c33k
Copy link
Owner

c33k commented Mar 22, 2021

Hi Artur.

Perfect! I wanted to use exactly this one, because I saw it on the website and loved it, but didn't see it on the Storebook.

It makes sense.

Will update to use this one.

Thx a lot!

@c33k c33k self-assigned this Mar 22, 2021
@c33k
Copy link
Owner

c33k commented Mar 22, 2021

@arturbien the DatePicker component is not exported on the latest dist.

https://github.com/arturbien/React95/blob/master/src/index.js

So I can't use it for now.

@c33k
Copy link
Owner

c33k commented Mar 22, 2021

@arturbien I've created a PR react95-io/React95#230 exporting it.
Not sure if you want to do it now, so block it in case it is not what you want for now.
Meanwhile, I'm testing the component locally in my machine.

Thanks a lot for letting me know.

@arturbien
Copy link
Author

The component is not exported because it's not ready yet for prod as it is a quite complex one. Mostly due to internationalization (month names / day name abbreviations) issues and other. You can see some discussion about it here: react95-io/React95#194

@arturbien
Copy link
Author

Damn, this comment supposed to go under the PR 😅 before the component is ready (and nobody is working on it rn) it's better for you to just copy the code and it integrate it in your codebase (you'll probably need to change import paths for components etc).

@c33k
Copy link
Owner

c33k commented Mar 23, 2021

Thx, @arturbien.

Yep, I'm working on it locally and it looks awesome. Thx for letting me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants