Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Elliptic Grid Solver #44

Open
juddmehr opened this issue Apr 24, 2024 · 1 comment
Open

Improve Elliptic Grid Solver #44

juddmehr opened this issue Apr 24, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@juddmehr
Copy link
Member

Currently, the elliptic grid solver defaults to applying a successive line over relaxation for several iterations, then applying a full newton solve to converge the grid down to 1e-14.

The jacobian for the grid elliptic system is very sparse, so we should implement a sparse jacobian for the newton method.

It may also be faster than a full newton to apply a quasi-newton method. This could also be explored, though the sparse jacobian should be done first probably.

@juddmehr juddmehr added the enhancement New feature or request label Apr 24, 2024
@juddmehr
Copy link
Member Author

juddmehr commented Nov 6, 2024

This is perhaps unnecessary with the recent reduction in state size associated with fixing bugs related to ImplicitAD implementation. Though it may be still worth looking into a sparse jacobian down the line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant