fix(binding): bug

1. when there is unexportable and no tags, omit the field
2. raw_body

Change-Id: I8d3ad16b2a6bcc26c523144c34c42b261516d14a

Author: andeya

binding/README.md

@@ -100,8 +100,9 @@ The parameter position in HTTP request:
 - Expression `required` or `req` indicates that the parameter is required
 - `default:"$value"` defines the default value for fallback when no binding is successful
 - If no position is tagged, try bind parameters from the body when the request has body,
-<br>otherwise try bind from the URL query
-- When there are multiple tags or no tags, the order in which to try to bind is:
+  <br>otherwise try bind from the URL query
+- When there is unexportable and no tags, omit the field
+- When there are multiple tags, or exportable and no tags, the order in which to try to bind is:
   1. path
   2. form
   3. query

binding/bind.go

@@ -314,7 +314,12 @@ func (b *Binding) getOrPrepareReceiver(value reflect.Value) (*receiver, error) {
 					break
 				}
 			}
-			// Support default binding order when there is no valid tag in the superior fields
+			if canDefault {
+				if !goutil.IsExportedName(p.structField.Name) {
+					canDefault = false
+				}
+			}
+			// Supports the default binding order when there is no valid tag in the superior field of the exportable field
 			if canDefault {
 				for _, i := range sortedDefaultIn {
 					if p.omitIns[i] {

binding/bind_test.go

@@ -20,33 +20,16 @@ import (
 
 func TestRawBody(t *testing.T) {
 	type Recv struct {
-		raw_body **struct {
-			A []byte   `raw_body:""`
-			B *[]byte  `raw_body:",required"`
-			C **[]byte `raw_body:"required"`
-			D string   `raw_body:""`
-			E *string  `raw_body:""`
-			F **string `raw_body:"" vd:"@:len($)<3; msg:'f too long'"`
-		}
-		S string `raw_body:""`
+		S []byte   `raw_body:""`
+		F **string `raw_body:"" vd:"@:len($)<3; msg:'f too long'"`
 	}
 	bodyBytes := []byte("raw_body.............")
 	req := newRequest("", nil, nil, bytes.NewReader(bodyBytes))
 	recv := new(Recv)
 	binder := binding.New(nil)
 	err := binder.BindAndValidate(recv, req, nil)
-	assert.EqualError(t, err, "validating: expr_path=raw_body.F, cause=f too long")
-	for _, v := range []interface{}{
-		(**recv.raw_body).A,
-		*(**recv.raw_body).B,
-		**(**recv.raw_body).C,
-		[]byte((**recv.raw_body).D),
-		[]byte(*(**recv.raw_body).E),
-		[]byte(**(**recv.raw_body).F),
-		[]byte(recv.S),
-	} {
-		assert.Equal(t, bodyBytes, v)
-	}
+	assert.EqualError(t, err, "validating: expr_path=F, cause=f too long")
+	assert.Equal(t, bodyBytes, []byte(recv.S))
 	bodyCopied, err := binding.GetBody(req)
 	assert.NoError(t, err)
 	assert.Equal(t, bodyBytes, bodyCopied.Bytes())
@@ -887,3 +870,23 @@ func TestQueryTypes(t *testing.T) {
 	assert.Equal(t, metric("e-from-cookie"), recv.E)
 	assert.Equal(t, filter{Col1: "abc"}, recv.F)
 }
+
+func TestNoTagIssue(t *testing.T) {
+	type x int
+	type T struct {
+		x
+		x2 x
+		a  int
+		B  int
+	}
+	req := newRequest("http://localhost:8080/?x=11&x2=12&a=1&B=2", nil, nil, nil)
+	recv := new(T)
+	binder := binding.New(nil)
+	binder.SetLooseZeroMode(true)
+	err := binder.BindAndValidate(recv, req, nil)
+	assert.NoError(t, err)
+	assert.Equal(t, x(0), recv.x)
+	assert.Equal(t, x(0), recv.x2)
+	assert.Equal(t, 0, recv.a)
+	assert.Equal(t, 2, recv.B)
+}

binding/receiver.go

@@ -64,7 +64,7 @@ func (r *receiver) assginIn(i in, v bool) {
 		r.hasPath = r.hasPath || v
 	case query:
 		r.hasQuery = r.hasQuery || v
-	case form, json, protobuf:
+	case form, json, protobuf, raw_body:
 		r.hasBody = r.hasBody || v
 	case cookie:
 		r.hasCookie = r.hasCookie || v