Skip to content

Commit c390a73

Browse files
committed
chore: remove codec tracing spans
These macros produce enormous slowdown in the bindgen Signed-off-by: Roman Volosatovs <[email protected]>
1 parent f11b835 commit c390a73

File tree

1 file changed

+2
-26
lines changed

1 file changed

+2
-26
lines changed

crates/wit-bindgen-rust/src/interface.rs

Lines changed: 2 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -963,7 +963,6 @@ impl<'a> wit_bindgen_core::InterfaceGenerator<'a> for InterfaceGenerator<'a> {
963963
let bytes = self.gen.bytes_path().to_string();
964964
let tokio = self.gen.tokio_path().to_string();
965965
let tokio_util = self.gen.tokio_util_path().to_string();
966-
let tracing = self.gen.tracing_path().to_string();
967966
let wrpc_transport = self.gen.wrpc_transport_path().to_string();
968967

969968
uwriteln!(
@@ -1196,9 +1195,7 @@ mod {mod_name} {{
11961195
type Item = super::{name};
11971196
type Error = ::std::io::Error;
11981197
1199-
fn decode(&mut self, src: &mut {bytes}::BytesMut) -> Result<Option<Self::Item>, Self::Error> {{
1200-
let span = {tracing}::trace_span!("decode", ty = "{ty_name}");
1201-
let _enter = span.enter();"#
1198+
fn decode(&mut self, src: &mut {bytes}::BytesMut) -> Result<Option<Self::Item>, Self::Error> {{"#
12021199
);
12031200
for Field { name, .. } in fields {
12041201
let name = to_rust_ident(name);
@@ -1234,9 +1231,7 @@ mod {mod_name} {{
12341231
type Error = ::std::io::Error;
12351232
12361233
#[allow(unused_mut)]
1237-
fn encode(&mut self, item: {name}, mut dst: &mut {bytes}::BytesMut) -> ::std::io::Result<()> {{
1238-
let span = {tracing}::trace_span!("encode", ty = "{ty_name}");
1239-
let _enter = span.enter();"#
1234+
fn encode(&mut self, item: {name}, mut dst: &mut {bytes}::BytesMut) -> ::std::io::Result<()> {{"#
12401235
);
12411236
if !fields.is_empty() {
12421237
self.push_str("let ");
@@ -1325,7 +1320,6 @@ pub struct {}(());",
13251320
let bitflags = self.gen.bitflags_path().to_string();
13261321
let bytes = self.gen.bytes_path().to_string();
13271322
let tokio_util = self.gen.tokio_util_path().to_string();
1328-
let tracing = self.gen.tracing_path().to_string();
13291323
let wasm_tokio = self.gen.wasm_tokio_path().to_string();
13301324
let wrpc_transport = self.gen.wrpc_transport_path().to_string();
13311325

@@ -1391,8 +1385,6 @@ mod {mod_name} {{
13911385
type Error = ::std::io::Error;
13921386
13931387
fn decode(&mut self, src: &mut {bytes}::BytesMut) -> Result<Option<Self::Item>, Self::Error> {{
1394-
let span = {tracing}::trace_span!("decode", ty = "{ty_name}");
1395-
let _enter = span.enter();
13961388
let n = src.len();
13971389
if n < {n} {{
13981390
src.reserve({n} - n);
@@ -1413,8 +1405,6 @@ mod {mod_name} {{
14131405
type Error = ::std::io::Error;
14141406
14151407
fn encode(&mut self, item: super::{name}, dst: &mut {bytes}::BytesMut) -> Result<(), Self::Error> {{
1416-
let span = {tracing}::trace_span!("encode", ty = "{ty_name}");
1417-
let _enter = span.enter();
14181408
dst.extend_from_slice(&item.bits().to_le_bytes());
14191409
Ok(())
14201410
}}
@@ -1516,7 +1506,6 @@ mod {mod_name} {{
15161506

15171507
let bytes = self.gen.bytes_path().to_string();
15181508
let tokio_util = self.gen.tokio_util_path().to_string();
1519-
let tracing = self.gen.tracing_path().to_string();
15201509
let wasm_tokio = self.gen.wasm_tokio_path().to_string();
15211510
let wrpc_transport = self.gen.wrpc_transport_path().to_string();
15221511

@@ -1556,8 +1545,6 @@ mod {mod_name} {{
15561545
type Error = ::std::io::Error;
15571546
15581547
fn decode(&mut self, src: &mut {bytes}::BytesMut) -> Result<Option<Self::Item>, Self::Error> {{
1559-
let span = {tracing}::trace_span!("decode", ty = "{ty_name}");
1560-
let _enter = span.enter();
15611548
let Some(disc) = {wasm_tokio}::Leb128DecoderU32.decode(src)? else {{
15621549
return Ok(None)
15631550
}};
@@ -1579,8 +1566,6 @@ mod {mod_name} {{
15791566
type Error = ::std::io::Error;
15801567
15811568
fn encode(&mut self, item: super::{name}, dst: &mut {bytes}::BytesMut) -> Result<(), Self::Error> {{
1582-
let span = {tracing}::trace_span!("encode", ty = "{ty_name}");
1583-
let _enter = span.enter();
15841569
{wasm_tokio}::Leb128Encoder.encode(match item {{"#
15851570
);
15861571
for (i, case) in cases.iter().enumerate() {
@@ -1673,8 +1658,6 @@ mod {mod_name} {{
16731658
type Error = ::std::io::Error;
16741659
16751660
fn encode(&mut self, item: {ty}, dst: &mut {bytes}::BytesMut) -> Result<(), Self::Error> {{
1676-
let span = {tracing}::trace_span!("encode", ty = "{ty_name}");
1677-
let _enter = span.enter();
16781661
match item {{"#
16791662
);
16801663
for (
@@ -1803,8 +1786,6 @@ mod {mod_name} {{
18031786
type Error = ::std::io::Error;
18041787
18051788
fn decode(&mut self, src: &mut {bytes}::BytesMut) -> Result<Option<Self::Item>, Self::Error> {{
1806-
let span = {tracing}::trace_span!("decode", ty = "{ty_name}");
1807-
let _enter = span.enter();
18081789
let state = if let Some(ref mut state) = self.0 {{
18091790
state
18101791
}} else {{
@@ -1999,7 +1980,6 @@ mod {mod_name} {{
19991980

20001981
let bytes = self.gen.bytes_path().to_string();
20011982
let tokio_util = self.gen.tokio_util_path().to_string();
2002-
let tracing = self.gen.tracing_path().to_string();
20031983
let wasm_tokio = self.gen.wasm_tokio_path().to_string();
20041984
let wrpc_transport = self.gen.wrpc_transport_path().to_string();
20051985

@@ -2038,8 +2018,6 @@ mod {mod_name} {{
20382018
type Error = ::std::io::Error;
20392019
20402020
fn decode(&mut self, src: &mut {bytes}::BytesMut) -> Result<Option<Self::Item>, Self::Error> {{
2041-
let span = {tracing}::trace_span!("decode", ty = "{ty_name}");
2042-
let _enter = span.enter();
20432021
let Some(disc) = {wasm_tokio}::Leb128DecoderU32.decode(src)? else {{
20442022
return Ok(None)
20452023
}};
@@ -2061,8 +2039,6 @@ mod {mod_name} {{
20612039
type Error = ::std::io::Error;
20622040
20632041
fn encode(&mut self, item: super::{name}, dst: &mut {bytes}::BytesMut) -> Result<(), Self::Error> {{
2064-
let span = {tracing}::trace_span!("encode", ty = "{ty_name}");
2065-
let _enter = span.enter();
20662042
{wasm_tokio}::Leb128Encoder.encode(match item {{"#
20672043
);
20682044
for (i, case) in enum_.cases.iter().enumerate() {

0 commit comments

Comments
 (0)