add and enable detekt.

Author: bytebeats

charts/build.gradle.kts

@@ -7,6 +7,7 @@ plugins {
     alias(libs.plugins.android.library)
     alias(libs.plugins.jetbrains.kotlin.android)
     alias(libs.plugins.jetbrains.dokka)
+    alias(libs.plugins.detekt.gradle.plugin)
     id("maven-publish")
     id("signing")
 }

charts/src/main/java/me/bytebeats/views/charts/Animations.kt

@@ -9,4 +9,4 @@ import androidx.compose.animation.core.TweenSpec
  * Quote: Peasant. Educated. Worker
  */
 
-fun simpleChartAnimation(): AnimationSpec<Float> = TweenSpec(durationMillis = 500)
+fun simpleChartAnimation(): AnimationSpec<Float> = TweenSpec(durationMillis = 500)

charts/src/main/java/me/bytebeats/views/charts/AxisLine.kt

@@ -26,4 +26,4 @@ data class AxisLine(
     fun paint(density: Density) {
         mPaint.strokeWidth = thickness.value * density.density
     }
-}
+}

charts/src/main/java/me/bytebeats/views/charts/TypeAlias.kt

@@ -7,4 +7,4 @@ package me.bytebeats.views.charts
  */
 
 typealias LabelFormatter = (value: Float) -> String
-typealias AxisLabelFormatter = (value: Any?) -> String
+typealias AxisLabelFormatter = (value: Any?) -> String

charts/src/main/java/me/bytebeats/views/charts/bar/BarChartData.kt

@@ -1,6 +1,7 @@
 package me.bytebeats.views.charts.bar
 
 import androidx.compose.ui.graphics.Color
+import me.bytebeats.views.charts.util.FLOAT_100
 
 /**
  * Created by bytebeats on 2021/9/25 : 13:52 E-mail: [email protected]
@@ -14,7 +15,7 @@ data class BarChartData(
 ) {
 
     init {
-        require(padBy in 0F..100F) {
+        require(padBy in 0F..FLOAT_100) {
             "padBy must be between 0F and 100F, included"
         }
         require(maxBarValue >= bars.maxOf { it.value }) {
@@ -30,10 +31,10 @@ data class BarChartData(
         }
 
     val maxY: Float
-        get() = yMinMaxValues.second + (yMinMaxValues.second - yMinMaxValues.first) * padBy / 100F
+        get() = yMinMaxValues.second + (yMinMaxValues.second - yMinMaxValues.first) * padBy / FLOAT_100
     val minY: Float
         get() = if (startAtZero) 0F
-        else yMinMaxValues.first - (yMinMaxValues.second - yMinMaxValues.first) * padBy / 100F
+        else yMinMaxValues.first - (yMinMaxValues.second - yMinMaxValues.first) * padBy / FLOAT_100
 
     data class Bar(
         val value: Float,

charts/src/main/java/me/bytebeats/views/charts/bar/BarCharts.kt

@@ -6,6 +6,8 @@ import androidx.compose.ui.graphics.drawscope.DrawScope
 import androidx.compose.ui.unit.dp
 import me.bytebeats.views.charts.bar.render.label.ILabelDrawer
 import me.bytebeats.views.charts.bar.render.xaxis.IXAxisDrawer
+import me.bytebeats.views.charts.util.FLOAT_10
+import me.bytebeats.views.charts.util.FLOAT_100
 
 /**
  * Created by bytebeats on 2021/9/25 : 13:57
@@ -22,7 +24,7 @@ internal fun axisAreas(
     with(drawScope) {
 
         val yAxisTop = labelDrawer.requiredAboveBarHeight(drawScope)
-        val yAxisRight = 50.dp.toPx().coerceAtMost(size.width * 10F / 100F)
+        val yAxisRight = 50.dp.toPx().coerceAtMost(size.width * FLOAT_10 / FLOAT_100)
         val xAxisRight = totalSize.width
         val xAxisTop = totalSize.height - xAxisDrawer.requiredHeight(drawScope)
 

charts/src/main/java/me/bytebeats/views/charts/bar/render/bar/IBarDrawer.kt

@@ -17,4 +17,4 @@ interface IBarDrawer {
         barArea: Rect,
         bar: BarChartData.Bar
     )
-}
+}

charts/src/main/java/me/bytebeats/views/charts/bar/render/label/ILabelDrawer.kt

@@ -19,4 +19,4 @@ interface ILabelDrawer {
         barArea: Rect,
         xAxisArea: Rect
     )
-}
+}

charts/src/main/java/me/bytebeats/views/charts/bar/render/label/SimpleLabelDrawer.kt

@@ -9,6 +9,7 @@ import androidx.compose.ui.unit.TextUnit
 import androidx.compose.ui.unit.sp
 import me.bytebeats.views.charts.AxisLabelFormatter
 import me.bytebeats.views.charts.toLegacyInt
+import me.bytebeats.views.charts.util.FLOAT_1_5
 
 /**
  * Created by bytebeats on 2021/9/25 : 14:01
@@ -30,7 +31,7 @@ data class SimpleLabelDrawer(
     }
 
     override fun requiredAboveBarHeight(drawScope: DrawScope): Float = when (drawLocation) {
-        DrawLocation.Outside -> 3F / 2F * labelTextHeight(drawScope)
+        DrawLocation.Outside -> FLOAT_1_5 * labelTextHeight(drawScope)
         else -> 0F
     }
 
@@ -59,7 +60,7 @@ data class SimpleLabelDrawer(
     }
 
     private fun labelTextHeight(drawScope: DrawScope): Float = with(drawScope) {
-        mLabelTextArea ?: (1.5F * labelTextSize.toPx())
+        mLabelTextArea ?: (FLOAT_1_5 * labelTextSize.toPx())
     }
 
     private fun paint(drawScope: DrawScope): android.graphics.Paint = with(drawScope) {
@@ -71,4 +72,4 @@ data class SimpleLabelDrawer(
         Outside,
         XAxis;
     }
-}
+}

charts/src/main/java/me/bytebeats/views/charts/bar/render/xaxis/IXAxisDrawer.kt

@@ -16,4 +16,4 @@ interface IXAxisDrawer {
         canvas: Canvas,
         drawableArea: Rect
     )
-}
+}