fix: maxBarValue not updated in a timely manner

junerver · junerver · commit 64abab8490f8 · 2024-11-15T19:31:36.000+08:00
diff --git a/app/src/main/java/me/bytebeats/views/charts/app/ui/screen/bar/BarChartDataModel.kt b/app/src/main/java/me/bytebeats/views/charts/app/ui/screen/bar/BarChartDataModel.kt
@@ -75,15 +75,16 @@ class BarChartDataModel {
         }
 
     internal fun addBar() {
-        barChartData = barChartData.copy(bars = bars.toMutableList().apply {
+        val newBars = bars.toMutableList().apply {
             add(
                 BarChartData.Bar(
                     label = "Bar ${bars.size + 1}",
                     value = randomValue(),
                     color = randomColor()
                 )
             )
-        }.toList())
+        }.toList()
+        barChartData = barChartData.copy(bars = newBars, maxBarValue = newBars.maxOf { it.value })
     }
 
     internal fun removeBar() {

Original file line number	Diff line number	Diff line change
`@@ -75,15 +75,16 @@ class BarChartDataModel {`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`internal fun addBar() {`
`78`		`- barChartData = barChartData.copy(bars = bars.toMutableList().apply {`
	`78`	`+ val newBars = bars.toMutableList().apply {`
`79`	`79`	`add(`
`80`	`80`	`BarChartData.Bar(`
`81`	`81`	`label = "Bar ${bars.size + 1}",`
`82`	`82`	`value = randomValue(),`
`83`	`83`	`color = randomColor()`
`84`	`84`	`)`
`85`	`85`	`)`
`86`		`- }.toList())`
	`86`	`+ }.toList()`
	`87`	`+ barChartData = barChartData.copy(bars = newBars, maxBarValue = newBars.maxOf { it.value })`
`87`	`88`	`}`
`88`	`89`
`89`	`90`	`internal fun removeBar() {`