-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deleting a subtitles line should also trigger a renumber #57
Comments
I have to think about it. On one hand it would make perfect sense to do it automatically, but in the other end some subtitle have sometimes some kind of tags as indexes, so it would lose data. I guess it could do it by default, and you could prevent it with That would require a minor version bump though. |
By the way until I issue a new version you can simply call Line 128 in 47aaa59
|
Sorry, I didn't find that function. |
The function clean_indexes should be called to trigger a re-indexing according to byroot/pysrt#57 .
I'm using your library to build a simple scripts which downloads subtitles from opensubtitles.org, removes all the unnecessary lines(synced by... and similar entries), saves the srt file and then encodes it into the video file with ffmpeg.
I've found that ffmpeg doesn't like srt files where there's a missing line, and it refuses to work with them.
This is what happens now:
when i run
I get
Which is not valid according to ffmpeg. Instead I should get
Can you please make that when I close an srt file, pysrt automatically renumbers all the lines, so that there are no interruptions?
The text was updated successfully, but these errors were encountered: