From f344aeff29b024d62787a9a6e5d6465740b1b29b Mon Sep 17 00:00:00 2001 From: AmberWagner Date: Tue, 3 Sep 2024 22:27:59 +0800 Subject: [PATCH 1/2] ci: change actions trigger events --- .github/workflows/rust-test.yaml | 5 ++++- .github/workflows/version.yaml | 2 +- .github/workflows/web-test.yaml | 5 ++++- src/routes/settings/+page.svelte | 2 +- 4 files changed, 10 insertions(+), 4 deletions(-) diff --git a/.github/workflows/rust-test.yaml b/.github/workflows/rust-test.yaml index d73b931..3b10e30 100644 --- a/.github/workflows/rust-test.yaml +++ b/.github/workflows/rust-test.yaml @@ -1,6 +1,9 @@ name: 'rust test' -on: push +on: + pull_request: + branches: + - main # This workflow will trigger on each push to the `release` branch to create or update a GitHub release, build your app, and upload the artifacts to the release. diff --git a/.github/workflows/version.yaml b/.github/workflows/version.yaml index a8fea9d..9ece5f5 100644 --- a/.github/workflows/version.yaml +++ b/.github/workflows/version.yaml @@ -1,7 +1,7 @@ name: 'version check' on: - pull_request: + push: branches: - 'release/*' diff --git a/.github/workflows/web-test.yaml b/.github/workflows/web-test.yaml index 293ba8c..3038798 100644 --- a/.github/workflows/web-test.yaml +++ b/.github/workflows/web-test.yaml @@ -1,6 +1,9 @@ name: 'web test' -on: push +on: + pull_request: + branches: + - main # This workflow will trigger on each push to the `release` branch to create or update a GitHub release, build your app, and upload the artifacts to the release. diff --git a/src/routes/settings/+page.svelte b/src/routes/settings/+page.svelte index 78bff20..4acc574 100644 --- a/src/routes/settings/+page.svelte +++ b/src/routes/settings/+page.svelte @@ -5,7 +5,7 @@ const update = (settingKey: keyof AppSettings) => (e: Event) => { calendarState.updateAppSettings({ [settingKey]: (e.target as HTMLInputElement).value as AppSettings[typeof settingKey] }); } - const toggle = (settingKey: keyof AppSettings) => (e: Event) => { + const toggle = (settingKey: keyof AppSettings) => async (e: Event) => { const checked = (e.target as HTMLInputElement).checked as boolean calendarState.updateAppSettings({ [settingKey]: checked }); From 84fd7a27abbf186aa9b57d4508edc15c5c64834a Mon Sep 17 00:00:00 2001 From: AmberWagner Date: Tue, 3 Sep 2024 22:31:15 +0800 Subject: [PATCH 2/2] ci: change action trigger to pull_request_target --- .github/workflows/rust-test.yaml | 2 +- .github/workflows/web-test.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/rust-test.yaml b/.github/workflows/rust-test.yaml index 3b10e30..daba8c7 100644 --- a/.github/workflows/rust-test.yaml +++ b/.github/workflows/rust-test.yaml @@ -1,7 +1,7 @@ name: 'rust test' on: - pull_request: + pull_request_target: branches: - main diff --git a/.github/workflows/web-test.yaml b/.github/workflows/web-test.yaml index 3038798..dc39d32 100644 --- a/.github/workflows/web-test.yaml +++ b/.github/workflows/web-test.yaml @@ -1,7 +1,7 @@ name: 'web test' on: - pull_request: + pull_request_target: branches: - main