Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADC Authentication #1440

Open
thoughtfuldata opened this issue Mar 16, 2024 · 2 comments
Open

ADC Authentication #1440

thoughtfuldata opened this issue Mar 16, 2024 · 2 comments

Comments

@thoughtfuldata
Copy link

thoughtfuldata commented Mar 16, 2024

I know this has been somewhat asked before but the related answers are quite old and some of the solutions no longer apply (i.e Google Drive API is no longer required)

How would this work with local Application Default Credentials(ADC) during development? ( i.e using gcloud auth application-default login).

from google.auth import default
creds, _ = default()
gc = gspread.authorize(creds)

print(type(creds))

I get "google.oauth2.credentials.Credentials" for the type

In deployment, I use a service account.

As a note: with GCSFS when using cloud storage this just works, trying to see what I'm doing wrong here.

Also, I have already tried using the service

gc = gspread.service_account(filename="./*.json")

and everything works

@lavigne958
Copy link
Collaborator

Hi thank you for this proposal, I recently looked into the default() function provided by Google auth package I wondered if it works.

It's great you confirm it does !

So far we could add some mention in the documentation and the main readme. So users can benefit from this setup.

Later this year I wish we could have this function as the default way of getting credentials.

@thoughtfuldata
Copy link
Author

thoughtfuldata commented Mar 27, 2024

@lavigne958 Actually, all a user needs to do is add the correct scope

DEFAULT_SCOPES = [
    "https://www.googleapis.com/auth/spreadsheets",
]
# Authenticate using ADC
creds, _ = google.auth.default(scopes=DEFAULT_SCOPES)  

and it works.

On the package side, gspread could assume the user uses ADC authentication( and that account has proper permissions) if a credentials.json isn't passed. This would cover most cases as Google recommends ADC authentication. This is similar to what GCSFS does. You can look at their docs GCSFS docs here and in the credentials section is where they explained their logic.

@alifeee alifeee added this to the 6.2.0 milestone May 10, 2024
@lavigne958 lavigne958 removed this from the 6.2.0 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants