Skip to content

Commit 5d2fb67

Browse files
committed
Clean up some duplicate size logic in GlideModifier.
1 parent b329401 commit 5d2fb67

File tree

1 file changed

+9
-8
lines changed
  • integration/compose/src/main/java/com/bumptech/glide/integration/compose

1 file changed

+9
-8
lines changed

integration/compose/src/main/java/com/bumptech/glide/integration/compose/GlideModifier.kt

+9-8
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import androidx.compose.ui.ExperimentalComposeUiApi
77
import androidx.compose.ui.Modifier
88
import androidx.compose.ui.draw.clipToBounds
99
import androidx.compose.ui.geometry.Size
10+
import androidx.compose.ui.geometry.isSpecified
1011
import androidx.compose.ui.graphics.ColorFilter
1112
import androidx.compose.ui.graphics.DefaultAlpha
1213
import androidx.compose.ui.graphics.drawscope.ContentDrawScope
@@ -38,7 +39,6 @@ import androidx.compose.ui.unit.IntOffset
3839
import androidx.compose.ui.unit.IntSize
3940
import androidx.compose.ui.unit.constrainHeight
4041
import androidx.compose.ui.unit.constrainWidth
41-
import androidx.compose.ui.unit.toSize
4242
import com.bumptech.glide.RequestBuilder
4343
import com.bumptech.glide.integration.ktx.AsyncGlideSize
4444
import com.bumptech.glide.integration.ktx.ExperimentGlideFlows
@@ -223,10 +223,10 @@ internal class GlideNode : DrawModifierNode, LayoutModifierNode, SemanticsModifi
223223
}
224224

225225
private val Size.isValidWidth
226-
get() = this != Size.Unspecified && this.width.isValidDimension
226+
get() = isSpecified && width.isValidDimension
227227

228228
private val Size.isValidHeight
229-
get() = this != Size.Unspecified && this.height.isValidDimension
229+
get() = isSpecified && height.isValidDimension
230230

231231
private val Float.isValidDimension
232232
get() = this > 0f && isFinite()
@@ -264,17 +264,18 @@ internal class GlideNode : DrawModifierNode, LayoutModifierNode, SemanticsModifi
264264
val srcSize = Size(srcWidth, srcHeight)
265265

266266
val scaledSize = if (size.isValid) {
267-
contentScale.computeScaleFactor(srcSize, size).times(srcSize).roundToInt()
267+
contentScale.computeScaleFactor(srcSize, size).times(srcSize)
268268
} else {
269-
Size.Zero.roundToInt()
269+
Size.Zero
270270
}
271271

272272
CachedPositionAndSize(
273273
alignment.align(
274-
IntSize(scaledSize.width, scaledSize.height),
275-
IntSize(size.width.roundToInt(), size.height.roundToInt()),
274+
scaledSize.roundToInt(),
275+
size.roundToInt(),
276276
layoutDirection
277-
).toPointF(), scaledSize.toSize()
277+
).toPointF(),
278+
scaledSize,
278279
)
279280
}
280281

0 commit comments

Comments
 (0)