Does adding tests to improve test coverage an useful task ? #1467
sateeshkumarb
started this conversation in
General & Learning
Replies: 1 comment
-
Hey Satish, great question! Adding tests would be a great way to start! We have a lot of work to do in that area so don't worry too much about burdening the team with PRs. As long as a test is testing some behavior of a function/worker we want to add it - at the same time we don't want to write brittle tests that test some implementation detail. Looking forward to your next contribution 🥳 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I think looking at tests (unit, integration) that are there for Ockam code base is a good start for a new contributor to become familiar with Ockam code base. In that context, does looking at code coverage that exists and adding unit tests to improve the coverage an useful activity for a new contributor ? What is the code coverage Ockam's team tries to maintain ? I do understand code coverage metrics in itself might not be a good indicator of the testing, and it has its drawback of providing false assurance (esp. with unit tests). So lot of PRs essentially adding unit tests alone might be burdensome for the Ockam core team too. Any thoughts ?
(My question is based on looking at Rust codebase, but I guess this point might be applicable to other lang implementations too.)
Beta Was this translation helpful? Give feedback.
All reactions