Removed unnecessary mapping

Author: Rostyslav Yeromchenko

data/src/main/java/org/buffer/android/boilerplate/data/BufferooDataRepository.kt

@@ -15,34 +15,37 @@ import javax.inject.Inject
  * data sources
  */
 class BufferooDataRepository @Inject constructor(private val factory: BufferooDataStoreFactory,
-                                                 private val bufferooMapper: BufferooMapper):
+                                                 private val bufferooMapper: BufferooMapper) :
         BufferooRepository {
 
     override fun clearBufferoos(): Completable {
         return factory.retrieveCacheDataStore().clearBufferoos()
     }
 
     override fun saveBufferoos(bufferoos: List<Bufferoo>): Completable {
-        val bufferooEntities = mutableListOf<BufferooEntity>()
-        bufferoos.map { bufferooEntities.add(bufferooMapper.mapToEntity(it)) }
-        return factory.retrieveCacheDataStore().saveBufferoos(bufferooEntities)
+        val bufferooEntities = bufferoos.map { bufferooMapper.mapToEntity(it) }
+        return saveBufferooEntities(bufferooEntities)
+    }
+
+    private fun saveBufferooEntities(bufferoos: List<BufferooEntity>): Completable {
+        return factory.retrieveCacheDataStore().saveBufferoos(bufferoos)
     }
 
     override fun getBufferoos(): Single<List<Bufferoo>> {
         val dataStore = factory.retrieveDataStore()
         return dataStore.getBufferoos()
-                .flatMap {
-                    val bufferoos = mutableListOf<Bufferoo>()
-                    it.map { bufferoos.add(bufferooMapper.mapFromEntity(it)) }
-                    Single.just(bufferoos)
-                }
                 .flatMap {
                     if (dataStore is BufferooRemoteDataStore) {
-                        saveBufferoos(it).toSingle { it }
+                        saveBufferooEntities(it).toSingle { it }
                     } else {
                         Single.just(it)
                     }
                 }
+                .map { list ->
+                    list.map { listItem ->
+                        bufferooMapper.mapFromEntity(listItem)
+                    }
+                }
     }
 
 }

remote/src/main/java/org/buffer/android/boilerplate/remote/BufferooRemoteImpl.kt

@@ -12,19 +12,18 @@ import javax.inject.Inject
  * operations in which data store implementation layers can carry out.
  */
 class BufferooRemoteImpl @Inject constructor(private val bufferooService: BufferooService,
-                                             private val entityMapper: BufferooEntityMapper):
+                                             private val entityMapper: BufferooEntityMapper) :
         BufferooRemote {
 
     /**
      * Retrieve a list of [BufferooEntity] instances from the [BufferooService].
      */
     override fun getBufferoos(): Single<List<BufferooEntity>> {
         return bufferooService.getBufferoos()
-                .map { it.team }
                 .map {
-                    val entities = mutableListOf<BufferooEntity>()
-                    it.forEach { entities.add(entityMapper.mapFromRemote(it)) }
-                    entities
+                    it.team.map { listItem ->
+                        entityMapper.mapFromRemote(listItem)
+                    }
                 }
     }