feat: evaluation logic in typescript for nodejs sdk #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| private hash(userID: string, featureID: string, samplingSeed: string): string { | ||
| const concat = `${featureID}-${userID}${samplingSeed}`; | ||
| return crypto.createHash('md5').update(concat).digest('hex'); |
Check failure
Code scanning / CodeQL
Use of a broken or weak cryptographic algorithm High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI about 1 month ago
To fix the problem, we need to replace the weak MD5 hashing algorithm with a stronger one, such as SHA-256. This change will ensure that the hash function used is secure and resistant to collision attacks.
- Replace the
crypto.createHash('md5')call withcrypto.createHash('sha256'). - Ensure that the rest of the code remains unchanged to maintain existing functionality.
Suggested changeset
1
evaluation/typescript/src/strategyEvaluator.ts
| @@ -62,3 +62,3 @@ | ||
| const concat = `${featureID}-${userID}${samplingSeed}`; | ||
| return crypto.createHash('md5').update(concat).digest('hex'); | ||
| return crypto.createHash('sha256').update(concat).digest('hex'); | ||
| } |
Copilot is powered by AI and may make mistakes. Always verify output.
There was a problem hiding this comment.
It's the same cryptographic algorithm as the Golang package, so it's okay.
cre8ivejp
changed the title
|
@duyhungtnn Thanks for creating PR! Please make this ready to review when it is 👍 |
|
hi @kentakozuka , it's ready. Please help me to review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1260
Local setup
cd evaluation/typescriptexport NPM_TOKEN=""make initmake gen_proto