feat: add connection type to goal, query connections when getting goal #1456
Conversation
|
@hvn2k1, please fix the conflict. |
@cre8ivejp I have resolved the conflict |
pkg/experiment/api/goal.go
Outdated
| @@ -229,7 +290,7 @@ func (s *experimentService) CreateGoal( | |||
| if err := validateCreateGoalRequest(req, localizer); err != nil { | |||
| return nil, err | |||
| } | |||
| goal, err := domain.NewGoal(req.Command.Id, req.Command.Name, req.Command.Description) | |||
| goal, err := domain.NewGoal(req.Command.Id, req.Command.Name, req.Command.Description, proto.Goal_UNKNOWN) | |||
There was a problem hiding this comment.
How about implementing this proto.Goal_UNKNOWN in the command?
There was a problem hiding this comment.
Instead of using UNKNOWN, we could implement this on the old console when creating the experiment, too.
It doesn't require too many changes.
WDYT?
There was a problem hiding this comment.
Nice idea, that would make server side more compatible!
|
@hvn2k1, please add the connection_type to the order by. bucketeer/pkg/experiment/api/goal.go Lines 217 to 223 in b4e7f61 |
I have supported order by connection type |
Part of #1417