Allow custom args

Author: vedharish

lib/browserstack/local.rb

@@ -49,10 +49,10 @@ def add_args(key, value=nil)
     elsif key == "forceproxy" && value.to_s != "false"
       @force_proxy_flag = "-forceproxy"
     else
-      if value.to_s.downcase != true || value.to_s.downcase! != false 
+      if value.to_s.downcase.eql?("true")
         @user_arguments << "-#{key}"
       else
-        @user_arguments << "-#{key} #{value}"
+        @user_arguments << "-#{key} '#{value}'"
       end
     end
   end
@@ -122,12 +122,11 @@ def stop
   end
 
   def command
-    "#{@exec} #{@binary_path} -logFile '#{@logfile}' #{@folder_flag} #{@key} #{@folder_path} #{@force_local_flag} #{@local_identifier_flag} #{@only_flag} #{@only_automate_flag} #{@proxy_host} #{@proxy_port} #{@proxy_user} #{@proxy_pass} #{@force_proxy_flag} #{@force_flag} #{@verbose_flag} #{@hosts}".strip
+    "#{@exec} #{@binary_path} -logFile '#{@logfile}' #{@folder_flag} #{@key} #{@folder_path} #{@force_local_flag} #{@local_identifier_flag} #{@only_flag} #{@only_automate_flag} #{@proxy_host} #{@proxy_port} #{@proxy_user} #{@proxy_pass} #{@force_proxy_flag} #{@force_flag} #{@verbose_flag} #{@hosts} #{@user_arguments.join(" ")}".strip
   end
 
   def command_args
-    args = ["#{@binary_path}", "-logFile", "#{@logfile}", "#{@key}", "#{@folder_flag}", "#{@folder_path}", "#{@force_local_flag}", "#{@local_identifier_flag}", "#{@only_flag}", "#{@only_automate_flag}", "#{@proxy_host}", "#{@proxy_port}", "#{@proxy_user}", "#{@proxy_pass}", "#{@force_proxy_flag}","#{@force_flag}", "#{@verbose_flag}", "#{@hosts}"]
-    args = args + @user_arguments
+    args = ["#{@binary_path}", "-logFile", "#{@logfile}", "#{@key}", "#{@folder_flag}", "#{@folder_path}", "#{@force_local_flag}", "#{@local_identifier_flag}", "#{@only_flag}", "#{@only_automate_flag}", "#{@proxy_host}", "#{@proxy_port}", "#{@proxy_user}", "#{@proxy_pass}", "#{@force_proxy_flag}","#{@force_flag}", "#{@verbose_flag}", "#{@hosts}", "#{@user_arguments.join(" ")}"]
     args = args.select {|a| a.to_s != "" }
     args.push(:err => [:child, :out])
     args

test/browserstack-local-test.rb

@@ -64,6 +64,20 @@ def test_set_local_identifier
     assert_match /\-localIdentifier \'randomString\'/, @bs_local.command
   end
 
+  def test_custom_boolean_argument
+    @bs_local.add_args "boolArg1"
+    @bs_local.add_args "boolArg2"
+    assert_match /\-boolArg1/, @bs_local.command
+    assert_match /\-boolArg2/, @bs_local.command
+  end
+
+  def test_custom_keyval
+    @bs_local.add_args "customKey1", "custom value1"
+    @bs_local.add_args "customKey2", "custom value2"
+    assert_match /\-customKey1 \'custom value1\'/, @bs_local.command
+    assert_match /\-customKey2 \'custom value2\'/, @bs_local.command
+  end
+
   def test_set_proxy
     @bs_local.add_args "proxyHost", "localhost"
     @bs_local.add_args "proxyPort", 8080