From bff0ed640c0deeb0b9dd132b69b3926d613ff860 Mon Sep 17 00:00:00 2001 From: Nikhil Agarwal Date: Mon, 13 Jan 2025 18:50:54 +0530 Subject: [PATCH] Add error exit code on failure --- bin/commands/runs.js | 4 ++-- bin/helpers/reporterHTML.js | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/bin/commands/runs.js b/bin/commands/runs.js index 99c6699c..0a439ff6 100644 --- a/bin/commands/runs.js +++ b/bin/commands/runs.js @@ -365,10 +365,10 @@ module.exports = function run(args, rawArgs) { } // Generate custom report! - reportGenerator(bsConfig, data.build_id, args, rawArgs, buildReportData, function(){ + reportGenerator(bsConfig, data.build_id, args, rawArgs, buildReportData, function(modifiedExitCode=exitCode){ utils.sendUsageReport(bsConfig, args, `${message}\n${dashboardLink}`, Constants.messageTypes.SUCCESS, null, buildReportData, rawArgs); markBlockEnd('postBuild'); - utils.handleSyncExit(exitCode, data.dashboard_url); + utils.handleSyncExit(modifiedExitCode, data.dashboard_url); }); } else if(!turboScaleSession){ let stacktraceUrl = getStackTraceUrl(); diff --git a/bin/helpers/reporterHTML.js b/bin/helpers/reporterHTML.js index 541a0a28..c12da320 100644 --- a/bin/helpers/reporterHTML.js +++ b/bin/helpers/reporterHTML.js @@ -105,6 +105,9 @@ let reportGenerator = async (bsConfig, buildId, args, rawArgs, buildReportData, logger.error('Generating the build report failed.'); logger.error(utils.formatRequest(error.response.statusText, error.response, error.response.data)); utils.sendUsageReport(bsConfig, args, message, messageType, errorCode, buildReportData, rawArgs); + if (cb){ + cb(Constants.ERROR_EXIT_CODE); + } return; } }