Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sbt-tpolecat and fix associated compilation warnings #12

Closed
mtomko opened this issue Feb 6, 2023 · 1 comment
Closed

Update sbt-tpolecat and fix associated compilation warnings #12

mtomko opened this issue Feb 6, 2023 · 1 comment
Assignees
@mtomko

Comments

@mtomko
Copy link
Collaborator

mtomko commented Feb 6, 2023

The latest release of the sbt-tpolecat plugin (https://github.com/typelevel/sbt-tpolecat/releases/tag/v0.4.2) fixes a bug that caused some compiler settings not to be used. These settings enable a large number of additional linting rules, and PoolQ has code that does not pass these lint rules.

We should enable the latest version of the plugin and fix all the compilation warnings. The vast majority of them appear to harmless "discarded non-Unit value" warnings in test assertions (which operate by side-effect). We could probably fix many of them by porting tests from ScalaTest to munit, but they can also be handled on a one-off basis by prefixing the problematic assertions with val _ = .
@mtomko
Copy link
Collaborator Author

mtomko commented Sep 5, 2023

Fixed in #22

@mtomko mtomko self-assigned this Sep 5, 2023
@mtomko mtomko closed this as completed Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mtomko mtomko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mtomko