Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntegrationTestSpec should not ignore leading/trailing whitespace by default #7560

Open
droazen opened this issue Nov 10, 2021 · 0 comments
Open
Labels
learn GATK Suitable for GATK beginners tests

Comments

@droazen
Copy link
Contributor

droazen commented Nov 10, 2021

IntegrationTestSpec currently ignores leading/trailing whitespace by default when doing its comparison against expected outputs. This is problematic given that whitespace can include things like field delimiters, leading to bugs like the one fixed in #7559

We should change the default to not ignore leading/trailing whitespace. Tests that have a legitimate reason for ignoring it can then explicitly opt-in by calling setTrimWhiteSpace()

@droazen droazen added tests learn GATK Suitable for GATK beginners labels Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
learn GATK Suitable for GATK beginners tests
Projects
None yet
Development

No branches or pull requests

1 participant