Revert "Revert "WX-1409 Java 17 (#7342)" (#7343)"

This reverts commit 227778a.

Author: aednichols

.github/set_up_cromwell_action/action.yml

@@ -3,7 +3,8 @@
 name: 'Set Up Cromwell Steps'
 description: Specific steps that will set up git secrets, java, sbt, and Cromwell on the local machine. 
 inputs:
-  cromwell_repo_token: #As an input to this action, you are required to pass in a token that can be used to authenticate while checking out Cromwell.
+  cromwell_repo_token:
+    description: "As an input to this action, you are required to pass in a token that can be used to authenticate while checking out Cromwell."
     required: true
 
 runs:
@@ -12,13 +13,13 @@ runs:
       #Allows this github action to use a cache to store stuff like Java and sbt files between runs.
       - uses: actions/checkout@v3
         name: Checkout Coursier Cache
-      - uses: coursier/cache-action@v6  
+      - uses: coursier/cache-action@v6
         name: Enable Coursier Cache
 
       #Cromwell requires git-secrets be setup. Here, we set up secrets and verify success with a script.
       - name: Git secrets setup 
         run: |
-          git clone https://github.com/awslabs/git-secrets.git ~/git-secrets
+          git clone --quiet https://github.com/awslabs/git-secrets.git ~/git-secrets
           cd ~/git-secrets
           git checkout ad82d68ee924906a0401dfd48de5057731a9bc84
           sudo make install
@@ -43,5 +44,4 @@ runs:
         uses: actions/setup-java@v3
         with:
           distribution: temurin
-          java-version: 11
-
+          java-version: 17

.github/workflows/chart_update_on_merge.yml

@@ -23,9 +23,10 @@ jobs:
         repository: broadinstitute/cromwell
         token: ${{ secrets.BROADBOT_GITHUB_TOKEN }} # Has to be set at checkout AND later when pushing to work
         path: cromwell
-    - uses: olafurpg/setup-scala@v10
+    - uses: actions/setup-java@v4
       with:
-        java-version: [email protected]
+        distribution: 'temurin'
+        java-version: '17'
     - name: Clone Cromwhelm
       uses: actions/checkout@v2
       with:

.github/workflows/docker_build_test.yml

@@ -25,9 +25,10 @@ jobs:
           repository: broadinstitute/cromwell
           token: ${{ secrets.BROADBOT_GITHUB_TOKEN }}
           path: cromwell
-      - uses: olafurpg/setup-scala@v10
+      - uses: actions/setup-java@v4
         with:
-          java-version: [email protected]
+          distribution: 'temurin'
+          java-version: '17'
       # The following invocation should be as similar as possible to the one in chart_update_on_merge.yml
       # To state the obvious: This test should not publish anything. It should simply verify that the build completes.
       - name: Build Cromwell Docker

.github/workflows/integration_tests.yml

@@ -104,6 +104,14 @@ jobs:
         set -e
         echo Running test.sh
         ./src/ci/bin/test.sh
+    # If a build step fails, activate SSH and idle for 60 minutes
+    # - name: Setup tmate session
+    #  if: ${{ failure() }}
+    #  uses: mxschmitt/action-tmate@v3
+    #  timeout-minutes: 60
+    #  with:
+    #    limit-access-to-actor: true
+    #    detached: true
     # always() is some github magic that forces the following step to run, even when the previous fails.
     # Without it, the if statement won't be evaluated on a test failure.
     - uses: ravsamhq/notify-slack-action@v2

.github/workflows/trivy.yml

@@ -20,9 +20,10 @@ jobs:
       - uses: actions/checkout@v2
 
       # fetch SBT package
-      - uses: olafurpg/setup-scala@v10
+      - uses: actions/setup-java@v4
         with:
-          java-version: [email protected]
+          distribution: 'temurin'
+          java-version: '17'
 
       # set up SBT cache
       - uses: actions/cache@v2

.sdkmanrc

@@ -1,3 +1,3 @@
 # Enable auto-env through the sdkman_auto_env config
 # Add key=value pairs of SDKs to use below
-java=11.0.11.hs-adpt
+java=17.0.9-tem

CHANGELOG.md

@@ -1,5 +1,12 @@
 # Cromwell Change Log
 
+## 87 Release Notes
+
+### Java 17
+
+As of this version, a distribution of Java 17 is required to run Cromwell. Cromwell is developed, tested, and
+containerized using [Eclipse Temurin](https://adoptium.net/temurin/releases/?version=17).
+
 ## 86 Release Notes
 
 ### GCP Batch

centaur/src/main/scala/centaur/api/DaemonizedDefaultThreadFactory.scala

@@ -14,8 +14,7 @@ import java.util.concurrent.atomic.AtomicInteger
   * > main thread).
   */
 object DaemonizedDefaultThreadFactory extends ThreadFactory {
-  private val s = System.getSecurityManager
-  private val group = if (s != null) s.getThreadGroup else Thread.currentThread.getThreadGroup
+  private val group = Thread.currentThread.getThreadGroup
   private val threadNumber = new AtomicInteger(1)
   private val namePrefix = "daemonpool-thread-"
 

cloud-nio/cloud-nio-spi/src/main/scala/cloud/nio/spi/CloudNioPath.scala

@@ -176,7 +176,7 @@ class CloudNioPath(filesystem: CloudNioFileSystem, private[spi] val unixPath: Un
   ): WatchKey = throw new UnsupportedOperationException
 
   override def iterator(): java.util.Iterator[Path] =
-    if (unixPath.isEmpty || unixPath.isRoot) {
+    if (unixPath.izEmpty || unixPath.isRoot) {
       java.util.Collections.emptyIterator()
     } else {
       unixPath.split().to(LazyList).map(part => newPath(UnixPath.getPath(part)).asInstanceOf[Path]).iterator.asJava

cloud-nio/cloud-nio-spi/src/main/scala/cloud/nio/spi/UnixPath.scala

@@ -67,7 +67,7 @@ final private[spi] case class UnixPath(path: String) extends CharSequence {
 
   def isAbsolute: Boolean = UnixPath.isAbsolute(path)
 
-  def isEmpty: Boolean = path.isEmpty
+  def izEmpty: Boolean = path.isEmpty
 
   def hasTrailingSeparator: Boolean = UnixPath.hasTrailingSeparator(path)