Skip to content

Commit 7b3613e

Browse files
committed
fix: inline reconciler constants #358
1 parent 3e9edb4 commit 7b3613e

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

packages/react-babylonjs/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-babylonjs",
3-
"version": "3.2.3",
3+
"version": "3.2.4",
44
"description": "React for Babylon.js",
55
"homepage": "https://brianzinn.github.io/react-babylonjs/",
66
"keywords": [

packages/react-babylonjs/src/ReactBabylonJSHostConfig.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@ import { Nullable } from '@babylonjs/core/types.js'
55
import { ValueAndUnit } from '@babylonjs/gui/2D/valueAndUnit.js'
66

77
import ReactReconciler, { Fiber, HostConfig } from 'react-reconciler'
8-
import {
9-
DiscreteEventPriority,
10-
ContinuousEventPriority,
11-
DefaultEventPriority,
12-
} from 'react-reconciler/constants.js'
8+
// import {
9+
// DiscreteEventPriority,
10+
// ContinuousEventPriority,
11+
// DefaultEventPriority,
12+
// } from 'react-reconciler/constants.js'
1313

1414
import { CreationType, GeneratedParameter } from './codeGenerationDescriptors'
1515
import { CreatedInstance, CreatedInstanceMetadata } from './CreatedInstance'
@@ -47,10 +47,10 @@ type HostContext = Container
4747
type TimeoutHandle = number | undefined
4848
type NoTimeout = number
4949

50-
// TODO: get from react-reconciler directly via import - /constants in typings, but not in NPM.
51-
// const DiscreteEventPriority = 0b0000000000000000000000000000001;
52-
// const ContinuousEventPriority = 0b0000000000000000000000000000100;
53-
// const DefaultEventPriority = 0b0000000000000000000000000010000;
50+
// NOTE: importing from react-reconciler directly was causing some issues with next.js (https://github.com/brianzinn/react-babylonjs/issues/358)
51+
const DiscreteEventPriority = 0b0000000000000000000000000000001
52+
const ContinuousEventPriority = 0b0000000000000000000000000000100
53+
const DefaultEventPriority = 0b0000000000000000000000000010000
5454

5555
// https://github.com/facebook/react/tree/main/packages/react-reconciler#getcurrenteventpriority
5656
// https://github.com/facebook/react/blob/main/packages/react-dom/src/events/ReactDOMEventListener.js#L410

packages/react-babylonjs/src/render.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import { ReactElement, version } from 'react'
22
import Reconciler, { FiberRoot, Reconciler as ReconcilerType } from 'react-reconciler'
33
import ReactBabylonJSHostConfig, { Container } from './ReactBabylonJSHostConfig'
4-
import { ConcurrentRoot } from 'react-reconciler/constants'
5-
4+
// import { ConcurrentRoot } from 'react-reconciler/constants'
5+
const ConcurrentRoot = 1
66
export const roots = new Map<Container, FiberRoot>()
77

88
export type RendererOptions = {

0 commit comments

Comments
 (0)