WIP

Author: brianlaoaws

.pre-commit-config.yaml

@@ -61,19 +61,23 @@ repos:
     - --no-warn-unused-ignores # https://github.com/python/mypy/issues/8823, https://github.com/python/mypy/issues/8990
 - repo: local
   hooks:
-  # - id: pylint-local
-  #   name: pylint-local
-  #   description: Run pylint in the local virtualenv
-  #   entry: pylint "setup.py" "src/" "python/" "tests/"
-  #   language: system
-  #   # ignore all files, run on hard-coded modules instead
-  #   pass_filenames: false
-  #   always_run: true
+  - id: pylint-local
+    name: pylint-local
+    description: Run pylint in the local virtualenv
+    entry: pylint "setup.py" "src/" "python/" "tests/"
+    language: system
+    # ignore all files, run on hard-coded modules instead
+    pass_filenames: false
+    always_run: true
   - id: pytest-local
     name: pytest-local
     description: Run pytest in the local virtualenv
     entry: >
       pytest
+      --cov-report=term
+      --cov-report=html
+      --cov="rpdk.python"
+      --cov="cloudformation_cli_python_lib"
       --durations=5
       "tests/"
     language: system

tests/lib/hook_test.py

@@ -485,6 +485,10 @@ def test_test_entrypoint_success():
         (OperationStatus.IN_PROGRESS, HookStatus.IN_PROGRESS),
         (OperationStatus.SUCCESS, HookStatus.SUCCESS),
         (OperationStatus.FAILED, HookStatus.FAILED),
+        (
+            OperationStatus.CHANGE_SET_SUCCESS_SKIP_STACK_HOOK,
+            HookStatus.CHANGE_SET_SUCCESS_SKIP_STACK_HOOK,
+        ),
     ],
 )
 def test_get_hook_status(operation_status, hook_status):

tests/lib/interface_test.py

@@ -185,8 +185,9 @@ def test_hook_progress_event_serialize_to_response_with_error_code(message):
     }
 
 
-# add this test back when
-# def test_operation_status_enum_matches_sdk(client):
-#     sdk = set(client.meta.service_model.shape_for("OperationStatus").enum)
-#     enum = set(OperationStatus.__members__)
-#     assert enum == sdk
+def test_operation_status_enum_matches_sdk(client):
+    sdk = set(client.meta.service_model.shape_for("OperationStatus").enum)
+    enum = set(OperationStatus.__members__)
+    # CHANGE_SET_SUCCESS_SKIP_STACK_HOOK is a status specific to Hooks
+    enum.remove("CHANGE_SET_SUCCESS_SKIP_STACK_HOOK")
+    assert enum == sdk