eslint: enable recommended ruleset (#3263)

Author: alxndrsn

.eslintrc

@@ -1,7 +1,7 @@
 {
   "plugins": ["@typescript-eslint", "prettier"],
   "parser": "@typescript-eslint/parser",
-  "extends": ["plugin:prettier/recommended", "prettier"],
+  "extends": ["eslint:recommended", "plugin:prettier/recommended", "prettier"],
   "ignorePatterns": ["node_modules", "coverage", "packages/pg-protocol/dist/**/*", "packages/pg-query-stream/dist/**/*"],
   "parserOptions": {
     "ecmaVersion": 2017,
@@ -17,5 +17,13 @@
       "args": "none"
     }],
     "no-unused-vars": "off"
-  }
+  },
+  "overrides": [
+    {
+      "files": ["*.ts", "*.mts", "*.cts", "*.tsx"],
+      "rules": {
+        "no-undef": "off"
+      }
+    }
+  ]
 }

packages/pg-cloudflare/src/index.ts

@@ -61,6 +61,7 @@ export class CloudflareSocket extends EventEmitter {
   }
 
   async _listen() {
+    // eslint-disable-next-line no-constant-condition
     while (true) {
       log('awaiting receive from CF socket')
       const { done, value } = await this._cfReader!.read()

packages/pg-connection-string/index.js

@@ -19,7 +19,7 @@ function parse(str) {
   let dummyHost = false
   if (/ |%[^a-f0-9]|%[a-f0-9][^a-f0-9]/i.test(str)) {
     // Ensure spaces are encoded as %20
-    str = encodeURI(str).replace(/\%25(\d\d)/g, '%$1')
+    str = encodeURI(str).replace(/%25(\d\d)/g, '%$1')
   }
 
   try {

packages/pg-native/index.js

@@ -183,8 +183,10 @@ Client.prototype._emitResult = function (pq) {
     case 'PGRES_TUPLES_OK':
     case 'PGRES_COMMAND_OK':
     case 'PGRES_EMPTY_QUERY':
-      const result = this._consumeQueryResults(this.pq)
-      this.emit('result', result)
+      {
+        const result = this._consumeQueryResults(this.pq)
+        this.emit('result', result)
+      }
       break
 
     case 'PGRES_COPY_OUT':

packages/pg-pool/test/idle-timeout-exit.js

@@ -11,7 +11,6 @@ if (module === require.main) {
   pool.query('SELECT NOW()', (err, res) => console.log('completed first'))
   pool.on('remove', () => {
     console.log('removed')
-    done()
   })
 
   setTimeout(() => {

packages/pg-protocol/src/buffer-reader.ts

@@ -46,6 +46,7 @@ export class BufferReader {
   public cstring(): string {
     const start = this.offset
     let end = start
+    // eslint-disable-next-line no-empty
     while (this.buffer[end++] !== 0) {}
     this.offset = end
     return this.buffer.toString(this.encoding, start, end - 1)

packages/pg-protocol/src/inbound-parser.test.ts

@@ -50,16 +50,8 @@ var rowWithBigOids = {
 }
 var bigOidDescBuff = buffers.rowDescription([rowWithBigOids])
 
-var emptyRowFieldBuf = new BufferList().addInt16(0).join(true, 'D')
-
 var emptyRowFieldBuf = buffers.dataRow([])
 
-var oneFieldBuf = new BufferList()
-  .addInt16(1) // number of fields
-  .addInt32(5) // length of bytes of fields
-  .addCString('test')
-  .join(true, 'D')
-
 var oneFieldBuf = buffers.dataRow(['test'])
 
 var expectedAuthenticationOkayMessage = {

packages/pg-protocol/src/parser.ts

@@ -328,16 +328,17 @@ export class Parser {
         }
         break
       case 10: // AuthenticationSASL
-        message.name = 'authenticationSASL'
-        message.mechanisms = []
-        let mechanism: string
-        do {
-          mechanism = this.reader.cstring()
-
-          if (mechanism) {
-            message.mechanisms.push(mechanism)
-          }
-        } while (mechanism)
+        {
+          message.name = 'authenticationSASL'
+          message.mechanisms = []
+          let mechanism: string
+          do {
+            mechanism = this.reader.cstring()
+            if (mechanism) {
+              message.mechanisms.push(mechanism)
+            }
+          } while (mechanism)
+        }
         break
       case 11: // AuthenticationSASLContinue
         message.name = 'authenticationSASLContinue'

packages/pg-query-stream/test/error.ts

@@ -75,7 +75,7 @@ describe('error recovery', () => {
     const client = new Client()
     const stmt = 'SELECT * FROM goose;'
     await client.connect()
-    return new Promise(async (resolve) => {
+    return new Promise((resolve) => {
       let queryError: Error | undefined
       client.query(stmt).catch((e) => {
         queryError = e
@@ -86,7 +86,7 @@ describe('error recovery', () => {
         assert(queryError, 'query should have errored due to client ending')
         resolve()
       })
-      await client.end()
+      client.end()
     })
   })
 

packages/pg/bench.js

@@ -25,6 +25,7 @@ const exec = async (client, q) => {
 const bench = async (client, q, time) => {
   let start = Date.now()
   let count = 0
+  // eslint-disable-next-line no-constant-condition
   while (true) {
     await exec(client, q)
     count++