Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support secrets from AWS Secrets Manager #1514

Open
natepage opened this issue Apr 18, 2023 · 4 comments
Open

Support secrets from AWS Secrets Manager #1514

natepage opened this issue Apr 18, 2023 · 4 comments

Comments

@natepage
Copy link

Hi there!

Would like to know if the idea of extending bref/secrets-loader to support fetching secrets from AWS Secrets Manager would be welcome?

If yes, would be happy to work on a PR 😄

@sladg
Copy link
Contributor

sladg commented Jun 6, 2023

We are currently printing env vars (fetching them from AWS Secrets Manager) in pipeline to file and including the env file in deployment. Not ideal, but works. Having direct support would be appreciated with possibility to change them without need for deployment, however, we faced an issue with SSH and OAuth keys being too big and exceeding Lambda's env var limit.

@mnapoli
Copy link
Member

mnapoli commented Jun 6, 2023

Hi! Working on this feature is not at the top of my priorities at the moment (for lack of time), but I'm happy to talk about company sponsoring so that I can prioritize this development ❤️ Feel free to reach out at [email protected]

@natepage
Copy link
Author

natepage commented Aug 8, 2023

Hi @mnapoli 👋
Thank you for taking the time to respond to me.

I can only imagine how time consuming it would be for you to look after Bref, as I said in my original message, if the idea of such feature was welcome I would be happy to work on a PR to avoid you having to do it, that's what open-source is for 😄

Based on the comment from @sladg here, and this issue on secrets-loader itself, it looks like I'm not the only one who would enjoy this feature.

So here is a PR I've put together: brefphp/secrets-loader#4

Thanks again for responding, and looking forward to hearing from you 😉

@mnapoli
Copy link
Member

mnapoli commented Aug 8, 2023

Hey @natepage that looks awesome, thanks for the PR!

I'll review that in more details ASAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants