Skip to content

Commit 8a46b7a

Browse files
committed
fix: improve drag preview alignment
Related to #596
1 parent 495efb0 commit 8a46b7a

File tree

7 files changed

+54
-30
lines changed

7 files changed

+54
-30
lines changed

package-lock.json

Lines changed: 11 additions & 24 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
@use 'form-js-editor-base.css';
2-
@use '@bpmn-io/draggle/dist/dragula.css';
2+
@use '@bpmn-io/draggle/dist/draggle.css';
33
@use '@bpmn-io/properties-panel/dist/assets/properties-panel.css';

packages/form-js-editor/package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@
99
},
1010
"./dist/assets/form-js-editor.css": "./dist/assets/form-js-editor.css",
1111
"./dist/assets/form-js-editor-base.css": "./dist/assets/form-js-editor-base.css",
12-
"./dist/assets/dragula.css": "./dist/assets/dragula.css",
12+
"./dist/assets/draggle.css": "./dist/assets/draggle.css",
13+
"./dist/assets/dragula.css": "./dist/assets/draggle.css",
1314
"./dist/assets/properties-panel.css": "./dist/assets/properties-panel.css",
1415
"./package.json": "./package.json"
1516
},
@@ -46,7 +47,7 @@
4647
"url": "https://github.com/bpmn-io"
4748
},
4849
"dependencies": {
49-
"@bpmn-io/draggle": "^4.0.0",
50+
"@bpmn-io/draggle": "^4.1.0",
5051
"@bpmn-io/form-js-viewer": "^1.7.3",
5152
"@bpmn-io/properties-panel": "^3.18.1",
5253
"array-move": "^3.0.1",

packages/form-js-editor/rollup.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ export default [
6969
copy({
7070
targets: [
7171
{ src: 'assets/form-js-editor-base.css', dest: 'dist/assets' },
72-
{ src: '../../node_modules/@bpmn-io/draggle/dist/dragula.css', dest: 'dist/assets' },
72+
{ src: '../../node_modules/@bpmn-io/draggle/dist/draggle.css', dest: 'dist/assets' },
7373
{ src: '../../node_modules/@bpmn-io/properties-panel/dist/assets/properties-panel.css', dest: 'dist/assets' }
7474
]
7575
})

packages/form-js-editor/src/features/dragging/Dragging.js

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -289,6 +289,41 @@ export class Dragging {
289289

290290
return !target.classList.contains(DRAG_NO_DROP_CLS);
291291
},
292+
293+
transformOffset: (offset, event, element) => {
294+
295+
if (element.classList.contains(DRAG_ROW_MOVE_CLS)) {
296+
297+
const rowOffset = {
298+
x: -5,
299+
y: -60
300+
};
301+
302+
return {
303+
left: event.clientX + rowOffset.x,
304+
top: event.clientY + rowOffset.y
305+
};
306+
307+
}
308+
309+
if (element.classList.contains(DRAG_MOVE_CLS)) {
310+
311+
const iconOffset = {
312+
x: -5,
313+
y: -15
314+
};
315+
316+
return {
317+
left: event.clientX + iconOffset.x,
318+
top: event.clientY + iconOffset.y
319+
};
320+
321+
}
322+
323+
return offset;
324+
325+
},
326+
292327
slideFactorX: 10,
293328
slideFactorY: 5
294329
};

packages/form-js-editor/test/spec/FormEditor.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -988,7 +988,7 @@ describe('FormEditor', function() {
988988
});
989989

990990

991-
it('should create and select new form field', async function() {
991+
it.only('should create and select new form field', async function() {
992992

993993
// given
994994
let dragulaCreated = false;

packages/form-js/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@
1818
},
1919
"./dist/assets/form-js.css": "./dist/assets/form-js.css",
2020
"./dist/assets/form-js-base.css": "./dist/assets/form-js-base.css",
21-
"./dist/assets/dragula.css": "./dist/assets/dragula.css",
21+
"./dist/assets/draggle.css": "./dist/assets/draggle.css",
22+
"./dist/assets/dragula.css": "./dist/assets/draggle.css",
2223
"./dist/assets/flatpickr/light.css": "./dist/assets/flatpickr/light.css",
2324
"./dist/assets/properties-panel.css": "./dist/assets/properties-panel.css",
2425
"./dist/assets/form-js-editor.css": "./dist/assets/form-js-editor.css",

0 commit comments

Comments
 (0)