Merge pull request #79 from mrbot-ai/connection-leak-fix

fixed connection leak when closing down component

Author: MatthieuJnon

CHANGELOG.md

@@ -1,8 +1,11 @@
+## 0.5.7
+- Fixed a bug where the connection would not close down when the component unmounted and continued polling indefinitely in the background.
+
 ## 0.5.6
-- fixed a bug where named links would not render in a received message
+- Fixed a bug where named links would not render in a received message
 
 ## 0.5.5
-- new prop, `docViewer`, if this props is true, this will treat every link in received messages as a document and will open it in a popup using docs.google.com/viewer (note: this is an experimental feature and should be used with caution)
+- New prop, `docViewer`, if this props is true, this will treat every link in received messages as a document and will open it in a popup using docs.google.com/viewer (note: this is an experimental feature and should be used with caution)
 
 ## 0.5.4
 - When reconnecting to an existing chat session, the bot will send a message contained in the localStorage key specified by the `NEXT_MESSAGE` constant. The message should be stringified JSON with a `message` property describing the message and an `expiry` property set to a UNIX timestamp in milliseconds after which this message should not be sent.

src/components/Widget/index.js

@@ -90,7 +90,9 @@ class Widget extends Component {
 
     socket.on('disconnect', (reason) => {
       console.log(reason);
-      this.props.dispatch(disconnectServer());
+      if (reason !== 'io client disconnect') {
+        this.props.dispatch(disconnectServer());
+      }
     });
 
     if (this.props.embedded && this.props.initialized) {
@@ -108,6 +110,11 @@ class Widget extends Component {
     }
   }
 
+  componentWillUnmount() {
+    const { socket } = this.props;
+    socket.close();
+  }
+
   getSessionId() {
     const { storage } = this.props;
     // Get the local session, check if there is an existing session_id

src/index.js

@@ -15,7 +15,7 @@ const ConnectedWidget = (props) => {
     sock,
     storage,
     props.docViewer,
-    );
+  );
   return (<Provider store={store}>
     <Widget
       socket={sock}