Skip to content

Commit e417eec

Browse files
committed
Fix for beta version not showing up in version drop down and beta release notes not being imported (#2004) (#2005)
1 parent 1e56c83 commit e417eec

File tree

3 files changed

+13
-7
lines changed

3 files changed

+13
-7
lines changed

versions/admin.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,14 @@ class VersionFileInline(admin.StackedInline):
1919

2020
@admin.register(models.Version)
2121
class VersionAdmin(admin.ModelAdmin):
22-
list_display = ["name", "release_date", "active", "full_release", "beta"]
22+
list_display = [
23+
"name",
24+
"release_date",
25+
"active",
26+
"full_release",
27+
"beta",
28+
"fully_imported",
29+
]
2330
list_filter = ["active", "full_release", "beta"]
2431
ordering = ["-release_date", "-name"]
2532
search_fields = ["name", "description"]

versions/releases.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -317,13 +317,11 @@ def process_release_notes(content):
317317
def store_release_notes_for_version(version_pk):
318318
"""Check S3 and then github for release notes and store them in RenderedContent."""
319319
# Get the version
320+
# todo: convert to task, remove the task that calls this, is redundant
320321
try:
321322
version = Version.objects.get(pk=version_pk)
322323
except Version.DoesNotExist:
323-
logger.info(
324-
"store_release_notes_for_version_error_version_not_found",
325-
version_pk=version_pk,
326-
)
324+
logger.info(f"store_release_notes version_not_found {version_pk=}")
327325
raise Version.DoesNotExist
328326

329327
content, processed_content, content_type = get_release_notes_for_version(version_pk)

versions/tasks.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
)
2323

2424

25-
logger = structlog.getLogger(__name__)
25+
logger = structlog.get_logger()
2626

2727

2828
@app.task
@@ -87,7 +87,7 @@ def import_release_notes(new_versions_only=True):
8787
versions = Version.objects.exclude(name__in=["master", "develop"]).active()
8888

8989
for version in versions:
90-
logger.info(f"retrieving release notes for {version.name=}")
90+
logger.info(f"retrieving release notes for {version.name=} {version.pk=}")
9191
store_release_notes_task.delay(str(version.pk))
9292
store_release_notes_in_progress_task.delay()
9393

@@ -204,6 +204,7 @@ def import_most_recent_beta_release(token=None, delete_old=False):
204204
import_version(name, tag, token=token, beta=True, full_release=False)
205205
logger.info(f"completed import_version with {name=} {tag=}")
206206
# new_versions_only='False' otherwise will only be full releases
207+
mark_fully_completed()
207208
import_release_notes(new_versions_only=False)
208209
return
209210

0 commit comments

Comments
 (0)