[fix] optional access err in with.

Author: klemens-morgenstern

include/boost/cobalt/detail/with.hpp

@@ -41,9 +41,9 @@ struct with_promise_value
       result.emplace(std::move(*value));
   }
 
-  T get_result()
+  std::optional<T> get_result()
   {
-    return std::move(result).value();
+    return std::move(result);
   }
 };
 
@@ -117,12 +117,12 @@ template<typename T>
 T with_impl<T>::await_resume()
 {
     auto e = promise.e;
-    auto res = std::move(promise.get_result());
+    auto res = promise.get_result();
     std::coroutine_handle<promise_type>::from_promise(promise).destroy();
     if (e)
         std::rethrow_exception(e);
 
-    return std::move(res);
+    return *std::move(res);
 }
 
 template<>

test/with.cpp

@@ -91,8 +91,9 @@ CO_TEST_CASE(async)
     BOOST_CHECK_THROW(
             co_await boost::cobalt::with (
                     &ft,
-                    [](finalizer_test * ) -> boost::cobalt::promise<void>
+                    [](finalizer_test * t) -> boost::cobalt::promise<void>
                     {
+                      co_await asio::post(t->exec);
                       throw std::runtime_error("42");
                       co_return;
                     },
@@ -146,4 +147,46 @@ CO_TEST_CASE(async_int)
 }
 
 
+CO_TEST_CASE(sync_int_throw)
+{
+  finalizer_test ft{co_await boost::cobalt::this_coro::executor};
+
+  BOOST_CHECK_THROW(
+              co_await boost::cobalt::with (
+                  &ft,
+                  [](finalizer_test *)
+                  {
+                    throw std::runtime_error("test");
+                    return 23;
+                  },
+                  [](finalizer_test * ft, std::exception_ptr &e)
+                  {
+                    return ft->exit(e);
+                  }), std::runtime_error);
+
+
+  BOOST_CHECK(ft.e != nullptr);
+}
+
+CO_TEST_CASE(async_int_throw)
+{
+  finalizer_test ft{co_await boost::cobalt::this_coro::executor};
+
+  BOOST_CHECK_THROW(
+      co_await boost::cobalt::with (
+          &ft,
+          [](finalizer_test * ) -> boost::cobalt::promise<int>
+          {
+            throw std::runtime_error("test");
+            co_return 42;
+          },
+          [](finalizer_test * ft, std::exception_ptr &e)
+          {
+            return ft->exit(e);
+          }), std::runtime_error);
+
+  BOOST_CHECK(ft.e != nullptr);
+}
+
+
 BOOST_AUTO_TEST_SUITE_END();