Skip to content

Executor::fetch_many impl should error on arguments or persistence #34

Open
@bobozaur

Description

@bobozaur

The QueryAs::fetch method from sqlx calls Executor::fetch_many underneath, so this change cannot be done now. A test was implemented to check against this.

When this test starts failing, check again whether the Executor::fetch_many can be made to fail on multi-statement queries that have arguments or are meant to be prepared.

If all looks good, then Executor::fetch_many can be made to exclusively call ExecuteBatch and possibly error out when it would otherwise prepare a statement or bind arguments.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions