Skip to content

Conversation

zfields
Copy link
Contributor

@zfields zfields commented Sep 1, 2025

No description provided.

@zfields zfields requested a review from Copilot September 1, 2025 17:28
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the heartbeat functionality to allow the heartbeat callback to signal when a request should be abandoned. The changes convert the heartbeat function from returning void to returning a boolean value indicating whether to abandon the current request.

Key changes:

  • Modified heartbeat function signature to return boolean instead of void
  • Updated heartbeat callback handling to check return value and break from retry loop when true
  • Added documentation explaining the new return value behavior

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
note.h Updated heartbeat function typedef to return bool instead of void
n_lib.h Updated internal heartbeat function declaration to return bool
n_hooks.c Modified heartbeat implementation to return callback result or false
n_request.c Added logic to check heartbeat return value and break retry loop

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@zfields zfields closed this Sep 2, 2025
@zfields zfields deleted the zak-abandon-heartbeat branch September 2, 2025 20:16
@zfields
Copy link
Contributor Author

zfields commented Sep 2, 2025

renamed branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant