Skip to content

Commit 0e97412

Browse files
mikewestCommit Bot
authored and
Commit Bot
committed
Adjusting //cookie/http-state tests name0031 and name0032.
Chrome and Firefox aligned on treating `"foo;bar"=baz` as a nameless cookie with a value of `"foo`, and `"foo\"bar;baz"=qux` as a nameless cookie with a value of `"foo\"bar`. That is, they both stop parsing the name/value pair when they hit a `;`. This seems aligned with step 1 of https://tools.ietf.org/html/draft-ietf-httpbis-rfc6265bis-05#section-5.3, which defines the `name-value-pair` as everything up to but not including the first `;`. Adjusting these tests accordingly, as discussed in httpwg/http-extensions#1136. Change-Id: I6930f8e18a8c573b21eaea5614e14c3b957ea0bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128135 Reviewed-by: Lily Chen <[email protected]> Commit-Queue: Mike West <[email protected]> Cr-Commit-Position: refs/heads/master@{#755255}
1 parent c174357 commit 0e97412

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

third_party/blink/web_tests/external/wpt/cookies/http-state/name-tests-expected.txt

+2-2
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ PASS name0027 - name0027
2929
FAIL name0028 - name0028 assert_equals: expected "" but got "a"
3030
PASS name0029 - name0029
3131
PASS name0030 - name0030
32-
FAIL name0031 - name0031 assert_equals: expected "" but got "\"foo"
33-
FAIL name0032 - name0032 assert_equals: expected "" but got "\"foo\\\"bar"
32+
PASS name0031 - name0031
33+
PASS name0032 - name0032
3434
FAIL name0033 - name0033 assert_equals: expected "" but got "aaa"
3535
Harness: the test ran to completion.
3636

Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Cookie: "foo
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Cookie: "foo\"bar

0 commit comments

Comments
 (0)