Skip to content

Move type hints from stubs to be inline #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sarahmonod opened this issue Jan 25, 2024 · 1 comment
Closed

Move type hints from stubs to be inline #59

sarahmonod opened this issue Jan 25, 2024 · 1 comment

Comments

@sarahmonod
Copy link
Contributor

As was raised with #58, having the type hints in a separate file, which was helpful when we supported python2.7 so that we could use a more reasonable syntax, is no longer helpful and makes it hard to evolve
the library without introducing type issues.

Moving the type hints to be inline would make it easier to change them if and when needed.

@godlygeek
Copy link
Contributor

Done in #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants