Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't change type of a topic in dev mode #4673

Closed
stuartwdouglas opened this issue Feb 26, 2025 · 1 comment
Closed

Can't change type of a topic in dev mode #4673

stuartwdouglas opened this issue Feb 26, 2025 · 1 comment
Assignees

Comments

@stuartwdouglas
Copy link
Collaborator

If you have a topic with a subscriber you can't change the type of the topic as the changes are not grouped into a single changeset.

If we have failed modules in dev mode we should likely always be re-attempting in new changesets.

@github-actions github-actions bot added the triage Issue needs triaging label Feb 26, 2025
@matt2e
Copy link
Collaborator

matt2e commented Feb 26, 2025

Is this the case for changing anything other modules depend on? Like changing a verb signature…
I was thinking about this yesterday and meant to test it out.
Possibly we should make the changeset failure event include which modules prevented it being merged in, and the engine could then group them as those dependant modules get rebuilt

@matt2e matt2e self-assigned this Mar 3, 2025
@github-actions github-actions bot removed the triage Issue needs triaging label Mar 3, 2025
@alecthomas alecthomas closed this as not planned Won't fix, can't repro, duplicate, stale Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants