Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should we have @VerbName annotation in JVM? #4640

Closed
worstell opened this issue Feb 25, 2025 · 2 comments · Fixed by #4769
Closed

should we have @VerbName annotation in JVM? #4640

worstell opened this issue Feb 25, 2025 · 2 comments · Fixed by #4769
Assignees
@stuartwdouglas

Comments

@worstell
Copy link
Contributor

worstell commented Feb 25, 2025 •
edited by wesbillman
Loading

what's the use-case? seems like casing should be normalized by the schema extractor so that cross-runtime serialization always works as expected

@VerbName("Wes")
@Verb
fun echo(req: EchoRequest): EchoResponse {
// ...
}

schema: verb Wes(echo.EchoRequest) echo.EchoResponse
@github-actions github-actions bot added the triage Issue needs triaging label Feb 25, 2025
@alecthomas alecthomas mentioned this issue Feb 25, 2025
Open
@alecthomas
Copy link
Collaborator

Answer: no!

@github-actions github-actions bot removed the triage Issue needs triaging label Mar 3, 2025
@alecthomas alecthomas reopened this Mar 3, 2025
@alecthomas
Copy link
Collaborator

This exists, will remove.

stuartwdouglas added a commit that referenced this issue Mar 4, 2025
@stuartwdouglas
chore: remove @VerbName
fb3434b 
fixes: #4640
@stuartwdouglas stuartwdouglas mentioned this issue Mar 4, 2025
Merged
stuartwdouglas added a commit that referenced this issue Mar 4, 2025
@stuartwdouglas
chore: remove @VerbName
8105d26 
fixes: #4640
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stuartwdouglas stuartwdouglas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove @VerbName block/ftl
4 participants
@alecthomas @stuartwdouglas @acerbusace @worstell