Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing a topic declaration did not cause errors for subscribers #4603

Closed
bradleydwyer opened this issue Feb 24, 2025 · 3 comments
Closed

Comments

@bradleydwyer
Copy link
Collaborator

@Export
@Topic(name = "prices", partitions = 1)
interface PriceTopic : WriteableTopic<Price, SinglePartitionMapper>

removing this left the topic available to the subscriber

//ftl:subscribe ticker.prices from=latest

and still visible in the console

module ticker {
  export topic prices ticker.Price  
    +partitions 1
@github-actions github-actions bot added the triage Issue needs triaging label Feb 24, 2025
@matt2e matt2e self-assigned this Feb 28, 2025
@github-actions github-actions bot removed the triage Issue needs triaging label Feb 28, 2025
@matt2e
Copy link
Collaborator

matt2e commented Feb 28, 2025

This would be due to kotlin modules not removing generated versions of deleted code. cc @stuartwdouglas.
These same steps work fine with go modules.

@matt2e matt2e removed their assignment Feb 28, 2025
@matt2e matt2e added the jvm label Feb 28, 2025
@matt2e
Copy link
Collaborator

matt2e commented Feb 28, 2025

We don't have a ticket for that issue though. Ill make one and mark this one a dupe of that

@matt2e
Copy link
Collaborator

matt2e commented Feb 28, 2025

Dupe of #4603

@matt2e matt2e closed this as completed Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants