Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adhere to new go2rtc defaults #16902

Open
felipecrs opened this issue Mar 3, 2025 · 1 comment
Open

Adhere to new go2rtc defaults #16902

felipecrs opened this issue Mar 3, 2025 · 1 comment
Labels
enhancement New feature or request pinned

Comments

@felipecrs
Copy link
Contributor

This issue is just a reminder to cleanup go2rtc create_config.py once go2rtc is upgraded to 1.9.9+.

  1. webrtc.listen can be removed
  2. webrtc.filter.candidates can be removed
@felipecrs felipecrs added the enhancement New feature or request label Mar 3, 2025
@leccelecce
Copy link
Contributor

I'm a bit uncertain about the decision in go2rtc to ignored anything in 172.16.0.0/12 on the basis of it being "Docker-like". That private network range was defined in an RFC in 1996 - it's a perfectly valid LAN range and doesn't necessarily relate to Docker at all. It's also not uncommon to change Docker's daemon.json config to use a different network range.

I would bet that most home users are using 192.168.x.x or 10.x.x.x but I think this risks breaking things for some users - have raised a query on the go2rtc project.

@NickM-27 NickM-27 added the pinned label Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pinned
Projects
None yet
Development

No branches or pull requests

3 participants