-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Story
thread-safe behind feature flag
#2
Comments
@bladecoder would you need some help to work on that feature? |
@IFcoltransG I like the way you propose to support threadsafe through a feature. I started to implement it in this branch and I realized it is not as easy as it seems. I used RwLock as substitute of RefCell but the methods are different, so we will need to implement these methods and use them in all the code. I have implemented the @LeCalicot Help is always welcome ! I let you complete this feature if you want. Just create a PR when you are finish and I will review it before merging. Thanks |
To be honest, it might take me a long time, I'm that good with rust yet. |
You can use |
@jaminhaber That's what I'm doing for a current project, but lack of |
There's some work going on to use Blade Ink in a Bevy game engine plugin for Ink, but Bevy strongly prefers
Send
types so it can parallelise. It would be valuable ifStory
wereSend
.For example, there could be a crate feature flag that replaces a
type Ref<T> = Rc<T>
withtype Ref<T> = Arc<T>
and similar forMutex
instead ofRefCell
. That way users who only need single-threaded can avoid the slight overhead ofArc
overRc
.The text was updated successfully, but these errors were encountered: