Skip to content

Commit ef6714f

Browse files
PM-29806: Move FlightRecorderWriter to the data module (#6270)
1 parent d09945d commit ef6714f

File tree

27 files changed

+69
-45
lines changed

27 files changed

+69
-45
lines changed

app/src/main/kotlin/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSource.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package com.x8bit.bitwarden.data.platform.datasource.disk
22

3+
import com.bitwarden.data.datasource.disk.model.FlightRecorderDataSet
34
import com.bitwarden.ui.platform.feature.settings.appearance.model.AppTheme
4-
import com.x8bit.bitwarden.data.platform.datasource.disk.model.FlightRecorderDataSet
55
import com.x8bit.bitwarden.data.platform.manager.model.AppResumeScreenData
66
import com.x8bit.bitwarden.data.platform.repository.model.UriMatchType
77
import com.x8bit.bitwarden.data.platform.repository.model.VaultTimeoutAction

app/src/main/kotlin/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSourceImpl.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ import androidx.core.content.edit
55
import com.bitwarden.core.data.repository.util.bufferedMutableSharedFlow
66
import com.bitwarden.core.data.util.decodeFromStringOrNull
77
import com.bitwarden.data.datasource.disk.BaseDiskSource
8+
import com.bitwarden.data.datasource.disk.model.FlightRecorderDataSet
89
import com.bitwarden.ui.platform.feature.settings.appearance.model.AppTheme
9-
import com.x8bit.bitwarden.data.platform.datasource.disk.model.FlightRecorderDataSet
1010
import com.x8bit.bitwarden.data.platform.manager.model.AppResumeScreenData
1111
import com.x8bit.bitwarden.data.platform.repository.model.UriMatchType
1212
import com.x8bit.bitwarden.data.platform.repository.model.VaultTimeoutAction

app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/di/PlatformManagerModule.kt

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import com.bitwarden.core.data.manager.toast.ToastManagerImpl
1212
import com.bitwarden.cxf.registry.CredentialExchangeRegistry
1313
import com.bitwarden.cxf.registry.dsl.credentialExchangeRegistry
1414
import com.bitwarden.data.manager.NativeLibraryManager
15-
import com.bitwarden.data.manager.file.FileManager
15+
import com.bitwarden.data.manager.flightrecorder.FlightRecorderWriter
1616
import com.bitwarden.data.repository.ServerConfigRepository
1717
import com.bitwarden.network.BitwardenServiceClient
1818
import com.bitwarden.network.service.EventService
@@ -66,8 +66,6 @@ import com.x8bit.bitwarden.data.platform.manager.event.OrganizationEventManager
6666
import com.x8bit.bitwarden.data.platform.manager.event.OrganizationEventManagerImpl
6767
import com.x8bit.bitwarden.data.platform.manager.flightrecorder.FlightRecorderManager
6868
import com.x8bit.bitwarden.data.platform.manager.flightrecorder.FlightRecorderManagerImpl
69-
import com.x8bit.bitwarden.data.platform.manager.flightrecorder.FlightRecorderWriter
70-
import com.x8bit.bitwarden.data.platform.manager.flightrecorder.FlightRecorderWriterImpl
7169
import com.x8bit.bitwarden.data.platform.manager.garbage.GarbageCollectionManager
7270
import com.x8bit.bitwarden.data.platform.manager.garbage.GarbageCollectionManagerImpl
7371
import com.x8bit.bitwarden.data.platform.manager.network.NetworkConfigManager
@@ -109,18 +107,6 @@ object PlatformManagerModule {
109107
application: Application,
110108
): AppStateManager = AppStateManagerImpl(application = application)
111109

112-
@Provides
113-
@Singleton
114-
fun provideFlightRecorderWriter(
115-
clock: Clock,
116-
fileManager: FileManager,
117-
dispatcherManager: DispatcherManager,
118-
): FlightRecorderWriter = FlightRecorderWriterImpl(
119-
clock = clock,
120-
fileManager = fileManager,
121-
dispatcherManager = dispatcherManager,
122-
)
123-
124110
@Provides
125111
@Singleton
126112
fun provideFlightRecorderManager(

app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/flightrecorder/FlightRecorderManager.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.x8bit.bitwarden.data.platform.manager.flightrecorder
22

3-
import com.x8bit.bitwarden.data.platform.datasource.disk.model.FlightRecorderDataSet
3+
import com.bitwarden.data.datasource.disk.model.FlightRecorderDataSet
44
import com.x8bit.bitwarden.data.platform.repository.model.FlightRecorderDuration
55
import kotlinx.coroutines.flow.StateFlow
66

app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/flightrecorder/FlightRecorderManagerImpl.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,9 @@ import android.content.IntentFilter
77
import com.bitwarden.core.data.manager.dispatcher.DispatcherManager
88
import com.bitwarden.core.data.util.concurrentMapOf
99
import com.bitwarden.core.data.util.toFormattedPattern
10+
import com.bitwarden.data.datasource.disk.model.FlightRecorderDataSet
11+
import com.bitwarden.data.manager.flightrecorder.FlightRecorderWriter
1012
import com.x8bit.bitwarden.data.platform.datasource.disk.SettingsDiskSource
11-
import com.x8bit.bitwarden.data.platform.datasource.disk.model.FlightRecorderDataSet
1213
import com.x8bit.bitwarden.data.platform.repository.model.FlightRecorderDuration
1314
import kotlinx.coroutines.CoroutineScope
1415
import kotlinx.coroutines.Job

app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/about/AboutViewModel.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,14 @@ import android.os.Parcelable
44
import androidx.lifecycle.SavedStateHandle
55
import androidx.lifecycle.viewModelScope
66
import com.bitwarden.core.data.manager.BuildInfoManager
7+
import com.bitwarden.data.datasource.disk.model.FlightRecorderDataSet
78
import com.bitwarden.data.repository.ServerConfigRepository
89
import com.bitwarden.data.repository.util.baseWebVaultUrlOrDefault
910
import com.bitwarden.ui.platform.base.BaseViewModel
1011
import com.bitwarden.ui.platform.manager.util.deviceData
1112
import com.bitwarden.ui.util.Text
1213
import com.bitwarden.ui.util.asText
1314
import com.bitwarden.ui.util.concat
14-
import com.x8bit.bitwarden.data.platform.datasource.disk.model.FlightRecorderDataSet
1515
import com.x8bit.bitwarden.data.platform.manager.LogsManager
1616
import com.x8bit.bitwarden.data.platform.manager.clipboard.BitwardenClipboardManager
1717
import com.x8bit.bitwarden.data.platform.repository.EnvironmentRepository

app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/about/util/FlightRecorderDataSetExtensions.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@ package com.x8bit.bitwarden.ui.platform.feature.settings.about.util
22

33
import com.bitwarden.core.data.util.toFormattedDateStyle
44
import com.bitwarden.core.data.util.toFormattedTimeStyle
5+
import com.bitwarden.data.datasource.disk.model.FlightRecorderDataSet
56
import com.bitwarden.ui.platform.resource.BitwardenString
67
import com.bitwarden.ui.util.Text
78
import com.bitwarden.ui.util.asText
8-
import com.x8bit.bitwarden.data.platform.datasource.disk.model.FlightRecorderDataSet
99
import java.time.Clock
1010
import java.time.Instant
1111
import java.time.format.FormatStyle

app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/flightrecorder/recordedLogs/RecordedLogsViewModel.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@ import android.os.Parcelable
44
import androidx.core.net.toUri
55
import androidx.lifecycle.SavedStateHandle
66
import androidx.lifecycle.viewModelScope
7+
import com.bitwarden.data.datasource.disk.model.FlightRecorderDataSet
78
import com.bitwarden.data.manager.file.FileManager
89
import com.bitwarden.data.manager.model.ZipFileResult
910
import com.bitwarden.ui.platform.base.BaseViewModel
1011
import com.bitwarden.ui.platform.resource.BitwardenString
1112
import com.bitwarden.ui.util.Text
1213
import com.bitwarden.ui.util.asText
13-
import com.x8bit.bitwarden.data.platform.datasource.disk.model.FlightRecorderDataSet
1414
import com.x8bit.bitwarden.data.platform.repository.SettingsRepository
1515
import com.x8bit.bitwarden.ui.platform.feature.settings.flightrecorder.recordedLogs.util.toViewState
1616
import dagger.hilt.android.lifecycle.HiltViewModel

app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/flightrecorder/recordedLogs/util/FlightRecorderDataSetExtensions.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@ package com.x8bit.bitwarden.ui.platform.feature.settings.flightrecorder.recorded
33
import com.bitwarden.core.data.util.toFormattedDateStyle
44
import com.bitwarden.core.data.util.toFormattedPattern
55
import com.bitwarden.core.data.util.toFormattedTimeStyle
6+
import com.bitwarden.data.datasource.disk.model.FlightRecorderDataSet
67
import com.bitwarden.ui.platform.resource.BitwardenString
78
import com.bitwarden.ui.util.Text
89
import com.bitwarden.ui.util.asText
9-
import com.x8bit.bitwarden.data.platform.datasource.disk.model.FlightRecorderDataSet
1010
import com.x8bit.bitwarden.data.platform.util.fileOf
1111
import com.x8bit.bitwarden.ui.platform.feature.settings.flightrecorder.recordedLogs.RecordedLogsState
1212
import com.x8bit.bitwarden.ui.platform.util.formatBytes

app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/BitwardenBuildInfoManagerImpl.kt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ class BitwardenBuildInfoManagerImpl : BuildInfoManager {
1212
override val applicationId: String
1313
get() = BuildConfig.APPLICATION_ID
1414

15+
override val applicationName: String get() = "Password Manager"
16+
1517
override val isFdroid: Boolean
1618
get() = BuildConfig.FLAVOR == "fdroid"
1719

@@ -39,4 +41,6 @@ class BitwardenBuildInfoManagerImpl : BuildInfoManager {
3941
"release" -> "prod"
4042
else -> BuildConfig.BUILD_TYPE
4143
}
44+
45+
override val buildAndFlavor: String get() = "${BuildConfig.BUILD_TYPE}/${BuildConfig.FLAVOR}"
4246
}

0 commit comments

Comments
 (0)