Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check modified time when reusing tmp dir #659

Open
s417-lama opened this issue May 1, 2019 · 1 comment
Open

Check modified time when reusing tmp dir #659

s417-lama opened this issue May 1, 2019 · 1 comment
Labels
bug:unexpected behaviour Technically not a bug, but behavior is surprising so should be treated like one help-wanted:starter Want help, and this issue is a great way to get started working on the code base

Comments

@s417-lama
Copy link

I recommend that an executable file check its modified time and that of tmp dir, so that old tmp dir is not be used if the executable file is newer than tmp dir.

Consider the case below,

  • compile with mix release --executable
  • execute _build/prod/rel/<app>/bin/<app>.run
  • tmp dir is created
  • recompile
  • execute newly created _build/prod/rel/<app>/bin/<app>.run
  • exe files in the old tmp dir are used

In this case, any modifications are not reflected to the executable files.
I think it is an unexpected behavior, especially for new users.

@bitwalker
Copy link
Owner

Seems like a good change to make, I'm happy to merge a PR for that, but I won't have time to get to it and test it myself for awhile unfortunately.

@bitwalker bitwalker added bug:unexpected behaviour Technically not a bug, but behavior is surprising so should be treated like one help-wanted:starter Want help, and this issue is a great way to get started working on the code base labels May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:unexpected behaviour Technically not a bug, but behavior is surprising so should be treated like one help-wanted:starter Want help, and this issue is a great way to get started working on the code base
Projects
None yet
Development

No branches or pull requests

2 participants